test(flatkv): wait for catchup before partial-loss digest compare#3516
Conversation
The dump-flatkv tool clones a snapshot + WAL into a temp dir and only retries 3 times if a live writer rolls a new snapshot and truncates the WAL mid-clone. Running the digest comparison right after a 20s sleep while the victim is still blocksyncing reliably loses that race on busy CI runners, panicking with "source kept churning". - increase default catchup timeout/tolerance - print per-node heights on catchup timeout for diagnosis
PR SummaryLow Risk Overview It adds configurable Reviewed by Cursor Bugbot for commit 208e601. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3516 +/- ##
==========================================
- Coverage 59.04% 58.21% -0.83%
==========================================
Files 2199 2129 -70
Lines 182096 173921 -8175
==========================================
- Hits 107510 101249 -6261
+ Misses 64935 63685 -1250
+ Partials 9651 8987 -664
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
The dump-flatkv tool clones a snapshot + WAL into a temp dir and only retries 3 times if a live writer rolls a new snapshot and truncates the WAL mid-clone. Running the digest comparison right after a 20s sleep while the victim is still blocksyncing reliably loses that race on busy CI runners, panicking with "source kept churning".
Describe your changes and provide context
Testing performed to validate your change