Skip to content

ci: use Docker Buildx + ECR registry cache for integration-test prepare-cluster#3539

Merged
amir-deris merged 1 commit into
mainfrom
amir/plt-431-speed-up-prepare-cluster-integration-test-step
Jun 3, 2026
Merged

ci: use Docker Buildx + ECR registry cache for integration-test prepare-cluster#3539
amir-deris merged 1 commit into
mainfrom
amir/plt-431-speed-up-prepare-cluster-integration-test-step

Conversation

@amir-deris

@amir-deris amir-deris commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace uncached docker build in prepare-cluster with Docker Buildx + ECR registry-backed layer cache, using dedicated cache tags (build-cache:integration-localnode, build-cache:integration-rpcnode) separate from the release build-cache:shared.
  • Add build-seid-in-localnode-ci Makefile target that compiles seid inside an already-loaded localnode container, avoiding a redundant image rebuild.
  • Fork PRs degrade gracefully to a cold build: AWS OIDC login uses continue-on-error, and cache refs are conditionally empty when auth fails. Cache writes (cache-to) are further restricted to push events to avoid cache thrashing on PRs.

Expected impact

Step Cold build Warm (Dockerfiles unchanged)
localnode image ~10–20+ min ~1–3 min
rpcnode image ~2–5 min ~30s–1 min
seid compile unchanged unchanged

@amir-deris amir-deris self-assigned this Jun 3, 2026
@amir-deris amir-deris changed the title Added buildx and ecr caching for seid images ci: use Docker Buildx + ECR registry cache for integration-test prepare-cluster Jun 3, 2026
@cursor

cursor Bot commented Jun 3, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Changes are limited to CI workflow and Makefile helpers; runtime chain behavior is unchanged, with graceful fallback when ECR is unavailable.

Overview
The prepare-cluster job in integration-test.yml no longer builds images via make build-integration-ci-artifacts. It now uses Docker Buildx to build and load sei-chain/localnode and sei-chain/rpcnode, with registry cache in Amazon ECR when AWS login succeeds.

AWS OIDC (id-token: write) and optional configure-aws-credentials / ECR login steps were added; both use continue-on-error so fork PRs without credentials still get cold builds. Cache writes (cache-to) run only on push events to limit PR cache churn. Checkout was bumped to v5, and seid is built with the new make build-seid-in-localnode-ci target, which assumes images are already present and only runs the in-container compile (via ensure-integration-ci-images).

Reviewed by Cursor Bugbot for commit d4b1c30. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 3, 2026, 12:49 PM

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d4b1c30. Configure here.

Comment thread .github/workflows/integration-test.yml
@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.28%. Comparing base (2151ba0) to head (d4b1c30).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3539      +/-   ##
==========================================
- Coverage   59.12%   58.28%   -0.85%     
==========================================
  Files        2213     2140      -73     
  Lines      182814   174431    -8383     
==========================================
- Hits       108096   101660    -6436     
+ Misses      64993    63725    -1268     
+ Partials     9725     9046     -679     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@amir-deris amir-deris added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit 1a1b8cd Jun 3, 2026
60 of 61 checks passed
@amir-deris amir-deris deleted the amir/plt-431-speed-up-prepare-cluster-integration-test-step branch June 3, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants