fix(giga): correct synchronous executor mode#3573
Merged
Merged
Conversation
PR SummaryCursor Bugbot is generating a summary for commit 0dadc5b. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
masih
approved these changes
Jun 10, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
- Coverage 59.18% 58.33% -0.86%
==========================================
Files 2210 2136 -74
Lines 183259 174723 -8536
==========================================
- Hits 108470 101931 -6539
+ Misses 64992 63701 -1291
+ Partials 9797 9091 -706
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sei-will
approved these changes
Jun 10, 2026
sei-will
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Incorporate the iterator fallback introduced in #3560 to giga's synchronous mode.
Testing performed to validate your change