made blocksync send StatusRequest after statesync completes (CON-350)

[pompon0]

The point is to make sure that blocksync pool is immediately aware of the already connected peers, rather than wait for the first StatusRequest broadcast. This has been achieved by delaying processPeerUpdates to after pool is created, which sends the request when a peer has been discovered.
Additionally, nullable consensusReactor field is an Option now.

[cursor]

PR Summary

Medium Risk
Changes blocksync concurrency and peer height discovery timing on the state-sync→block-sync path; mistakes could delay catch-up or mishandle consensus handoff, but scope is limited to sync controller lifecycle.

Overview
Blocksync peer discovery after state sync is fixed by starting processPeerUpdates only after blocksyncReady and the BlockPool exist, instead of at the beginning of syncController.run. Peer-up handling still sends StatusRequest per peer, but that loop now runs alongside requestRoutine once catch-up actually starts, so peers already connected during state sync are queried immediately instead of waiting for the periodic broadcast.

ConsReactor is modeled as utils.Option[ConsensusReactor] (exported interface) instead of a nullable pointer, with wiring updated in node.go and tests.

Several blocksync background tasks (processBlockSyncCh, requestRoutine, processPeerUpdates) now return error for scope/service shutdown. The query-responder test no longer expects an unsolicited StatusRequest on connect when block sync is disabled, since peer-update-driven status requests only run during active sync.

^{Reviewed by Cursor Bugbot for commit b5ea71a. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
✅ passed	✅ passed	✅ passed	✅ passed	Jun 11, 2026, 2:30 PM

[codecov]

Codecov Report

❌ Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.33%. Comparing base (09c70ba) to head (b5ea71a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
sei-tendermint/internal/blocksync/reactor.go	67.56%	11 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3574      +/-   ##
==========================================
- Coverage   59.17%   58.33%   -0.85%     
==========================================
  Files        2215     2141      -74     
  Lines      183370   174810    -8560     
==========================================
- Hits       108512   101970    -6542     
+ Misses      65047    63738    -1309     
+ Partials     9811     9102     -709     

Flag	Coverage Δ
sei-chain-pr	68.31% <68.42%> (?)
sei-db	70.41% <ø> (ø)
sei-db-state-db	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
sei-tendermint/node/node.go	64.23% <100.00%> (ø)
sei-tendermint/internal/blocksync/reactor.go	68.19% <67.56%> (-1.08%)	⬇️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit b5ea71a. Configure here.}

[cursor]

Request routine survives blocksync end

Medium Severity

requestRoutine is now started as an outer-scope main task before scope.Run1, instead of a background task inside the blocksync session. After poolRoutine finishes and the node switches to consensus, it keeps handling pool.Requests(), pool.Errors(), and periodic StatusRequest broadcasts for the rest of the process lifetime.

 

^{Reviewed by Cursor Bugbot for commit b5ea71a. Configure here.}

[pompon0]

WAI, autorestartIfBehind relies on this.