Remove unused parquet and duckdb receipt store#3580
Conversation
Remove the experimental / unused parquet and duckdb receipt store. Remove redundant tests and adjust benchmarking.
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3580 +/- ##
==========================================
- Coverage 59.22% 58.35% -0.87%
==========================================
Files 2213 2140 -73
Lines 183115 174646 -8469
==========================================
- Hits 108453 101920 -6533
+ Misses 64914 63651 -1263
+ Partials 9748 9075 -673
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
PR SummaryMedium Risk Overview Config and ops now treat pebbledb/pebble as the sole supported backend: app TOML templates, Dependencies drop Reviewed by Cursor Bugbot for commit 7303849. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0fca0ae6f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -142,13 +141,12 @@ func NewRecieptStoreSimulator( | |||
| Backend: "parquet", | |||
There was a problem hiding this comment.
Use a supported receipt backend in cryptosim
When the cryptosim receipt simulator is created, this hard-coded Backend: "parquet" now goes through receipt.NewReceiptStoreWithReadMetrics, but this commit removed the parquet implementation and newReceiptBackend only accepts the pebble backend. As a result any cryptosim run that enables receipt generation/reads fails during simulator initialization with unsupported receipt store backend: parquet, so the receipt benchmark can no longer start.
Useful? React with 👍 / 👎.
cody-littley
left a comment
There was a problem hiding this comment.
LGTM. Please get signoff with @Kbhat1 before merging, as he's currently in charge of managing all recieptDB stuff.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7303849. Configure here.
| case receiptReadModeDuckDB: | ||
| if latest <= cacheWindow { | ||
| return | ||
| } |
There was a problem hiding this comment.
Cryptosim log filters always error
Medium Severity
After the receipt store is pebble-only, executeLogFilterRead still calls ReceiptStore.FilterLogs, which returns ErrRangeQueryNotSupported. Log-filter benchmark goroutines therefore record errors on every tick instead of exercising a supported read path.
Reviewed by Cursor Bugbot for commit 7303849. Configure here.
| crand: crand, | ||
| txRing: txRing, | ||
| metrics: metrics, | ||
| receiptCacheWindowBlocks: receipt.StableReceiptCacheWindowBlocks(store), |
There was a problem hiding this comment.
Cache window never initialized
Medium Severity
receiptCacheWindowBlocks on RecieptStoreSimulator is never set, so it stays zero. With ReceiptLogFilterReadMode or ReceiptReadMode set to "cache", the cache-window math collapses and log-filter reads often return immediately without querying.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 7303849. Configure here.
Re-adds the Linux AMD64 static-build job to cross-arch-build.yml. It builds seid with LINK_STATICALLY=true BUILD_TAGS=muslc CC=musl-gcc and asserts the result is statically linked (file + ldd), matching .goreleaser.yaml. The job was stripped in #3426 to land that PR while the duckdb/parquet linker blocker was unresolved; duckdb has since been removed from main (#3580), so the static build links cleanly again. The uci reusable @ref is intentionally left on the personal branch; it will be pinned to v0.0.10 only after uci#35 merges and is tagged.


Remove the experimental / unused parquet and duckdb receipt store. Remove redundant tests and adjust benchmarking.