conditional deactivation of consensus timeout overrides in config#3601
Conversation
PR SummaryHigh Risk Overview When overrides are disabled, config overrides are ignored unless on-chain timeouts still match the hard-coded Consensus Reviewed by Cursor Bugbot for commit ab5f001. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
- Coverage 58.96% 58.18% -0.78%
==========================================
Files 2208 2134 -74
Lines 181757 173832 -7925
==========================================
- Hits 107164 101152 -6012
+ Misses 64976 63713 -1263
+ Partials 9617 8967 -650
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| Vote: 50 * time.Millisecond, | ||
| VoteDelta: 500 * time.Millisecond, | ||
| Commit: 50 * time.Millisecond, | ||
| BypassCommitTimeout: false, |
There was a problem hiding this comment.
Is this the same as DefaultTimeoutParams?
There was a problem hiding this comment.
huh, indeed. Perhaps timeouts are currently not set at all.
| t = t.Or(types.DefaultTimeoutParams()) | ||
| // Overrides are effective iff UnsafeOverridesEnabled OR t == badParams: | ||
| // see doc on badParams. | ||
| if !c.UnsafeOverridesEnabled && t != badParams { |
There was a problem hiding this comment.
Our gov proposal will always override all params at the same time right? It would be a headache if proposal updates some args while override updates some.
There was a problem hiding this comment.
proposal updates everything atomically, yes. It wouldn't make sense otherwise.
There was a problem hiding this comment.
correct, all happens within a block
| Vote: 50 * time.Millisecond, | ||
| VoteDelta: 500 * time.Millisecond, | ||
| Commit: 50 * time.Millisecond, | ||
| BypassCommitTimeout: false, |
In 6.6 release we want to disable the overrides support.
Overrides can only be disabled AFTER onchain params are updated via government proposal.
Govenment proposal needs to wait for changes deployed in 6.6.
Disabling overrides needs to be synchronized across the network.
We need ability to reenable overrides for disaster recovery (chain halt).
To achieve that we: