Skip to content

[codex] remove sei debug trace exclude endpoints#3618

Merged
philipsu522 merged 3 commits into
mainfrom
codex/remove-sei-debug-trace-endpoints
Jun 22, 2026
Merged

[codex] remove sei debug trace exclude endpoints#3618
philipsu522 merged 3 commits into
mainfrom
codex/remove-sei-debug-trace-endpoints

Conversation

@codchen

@codchen codchen commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the legacy sei_traceBlockByNumberExcludeTraceFail and sei_traceBlockByHashExcludeTraceFail RPC endpoints.

Because those were the only methods on SeiDebugAPI, this also removes the SeiDebugAPI wrapper and its sei namespace debug registration. The related legacy allowlist entries, config examples, RPC IO fixtures, docs, and endpoint-specific tests were removed as well.

Impact

Clients should use the standard debug_traceBlockByNumber and debug_traceBlockByHash endpoints for block tracing. The remaining legacy *ExcludeTraceFail block and receipt APIs are unchanged.

Validation

  • go test ./evmrpc ./evmrpc/tests
  • git diff --check

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJun 22, 2026, 2:36 PM

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.13%. Comparing base (4c2d157) to head (5070cb8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
- Coverage   59.01%   58.13%   -0.89%     
==========================================
  Files        2224     2141      -83     
  Lines      182814   173867    -8947     
==========================================
- Hits       107892   101081    -6811     
+ Misses      65221    63802    -1419     
+ Partials     9701     8984     -717     
Flag Coverage Δ
sei-chain-pr 68.35% <ø> (?)
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/config/config.go 71.90% <ø> (ø)
evmrpc/sei_legacy.go 73.13% <ø> (ø)
evmrpc/server.go 88.46% <ø> (-0.28%) ⬇️
evmrpc/tracers.go 68.93% <ø> (-0.42%) ⬇️
evmrpc/utils.go 73.61% <ø> (ø)

... and 127 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen marked this pull request as ready for review June 22, 2026 13:24
@cursor

cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Breaking RPC removal for any client still calling the two sei_trace*ExcludeTraceFail methods; scope is limited to deprecated legacy trace APIs with a documented debug_* replacement.

Overview
Removes the legacy sei_traceBlockByNumberExcludeTraceFail and sei_traceBlockByHashExcludeTraceFail JSON-RPC methods, including the trace-cache filtering path (dropUntraceableTraces, filterExcludeFailFromBlockCache) that only served those calls.

Because those methods were the sole handlers on SeiDebugAPI, the PR drops that wrapper and stops registering a sei-namespace debug service on the HTTP EVM server; debug_traceBlockByNumber / debug_traceBlockByHash are unchanged.

Also cleans up allowlist entries in enabled_legacy_sei_apis (docker configs, evmrpc/sei_legacy.go, config template), docs (evmrpc/README.md), integration RPC IO fixtures/README rows, and Hardhat/Go tests tied to the removed APIs. Comments on isPanicOrSyntheticTx / isReceiptUntraceable now note they still support the remaining sei_get*ExcludeTraceFail block and receipt endpoints.

Client impact: callers on the removed trace methods must switch to standard debug_* block tracing; other *ExcludeTraceFail sei_* APIs are untouched.

Reviewed by Cursor Bugbot for commit 5070cb8. Bugbot is set up for automated code reviews on this repo. Configure here.

@philipsu522 philipsu522 added this pull request to the merge queue Jun 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 22, 2026
@philipsu522 philipsu522 enabled auto-merge June 22, 2026 14:04
@philipsu522 philipsu522 added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit 4d449ae Jun 22, 2026
60 checks passed
@philipsu522 philipsu522 deleted the codex/remove-sei-debug-trace-endpoints branch June 22, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants