Backport release/v6.6: fix(metrics): Prometheus metrics output#3673
Conversation
After the `sei-chain` to `sei_chain` prefix change in #3554, it surfaced that otel labels also had invalid Prometheus label characters ('.') Tested on local Sei node, with this patch the Prometheus remote write endpoint no longer drops any metrics from the node. Example before: ``` curl -si -H "Accept: application/openmetrics-text;version=1.0.0;escaping=allow-utf-8" http://127.0.0.1:26660/metrics | grep 'telemetry.sdk.language' target_info{"service.name"="unknown_service:seid","telemetry.sdk.language"="go","telemetry.sdk.name"="opentelemetry","telemetry.sdk.version"="1.39.0"} 1 ``` after: ``` curl -si -H "Accept: application/openmetrics-text;version=1.0.0;escaping=allow-utf-8" http://127.0.0.1:26660/metrics | grep 'telemetry.sdk.language' target_info{service_name="unknown_service:seid",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="1.39.0"} 1 ``` --------- Co-authored-by: Philip Su <philip.su.522@gmail.com> (cherry picked from commit 2378fca)
PR SummaryLow Risk Overview Both OTel Prometheus setup paths now pass Reviewed by Cursor Bugbot for commit 5ab8f40. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v6.6 #3673 +/- ##
================================================
- Coverage 58.88% 58.00% -0.88%
================================================
Files 2225 2151 -74
Lines 183482 174939 -8543
================================================
- Hits 108041 101481 -6560
+ Misses 65733 64450 -1283
+ Partials 9708 9008 -700
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3 participants
Backport of #3640 to
release/v6.6.