fix: revert default WriteMode to cosmos_only for stable seid v6.5.1#27
Merged
Conversation
PR SummaryMedium Risk Overview Defaults in Validation in Package version bumps v0.0.18 → v0.0.19 in Reviewed by Cursor Bugbot for commit 1f8f69e. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Suggested version: Changes in (empty)
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
v0.0.18 defaulted WriteMode to memiavl_only, which the stable released seid (v6.5.1) rejects with "invalid write mode: memiavl_only". Both v6.5.1 and nightly run simultaneously, so new nodes without explicit overrides broke on v6.5.1. The sei-config default tracks the stable released binary: v6.5.1 accepts cosmos_only. Nightly/main callers (SND templates) override to memiavl_only explicitly. Bump the default when 6.6.0 ships memiavl_only. This also corrects WriteMode.IsValid to accept the deprecated v1 modes (cosmos_only, dual_write, split_write): they are real values the stable binary consumes, not invalid input. The v1->v2 migration still renames them, so migrated configs converge on the v2 names. No DefaultForVersion abstraction is added — the binary-version axis is a single default value plus a caller override, which the existing override pipeline handles. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
bdchatham
force-pushed
the
fix/revert-memiavl-default
branch
from
a05db9e to
1f8f69e
Compare
bdchatham
added a commit
to sei-protocol/seictl
that referenced
this pull request
May 27, 2026
Picks up [sei-config#27](sei-protocol/sei-config#27) — reverts default `WriteMode` to `cosmos_only` so stable seid v6.5.1 nodes don't break. Paired with sei-k8s-controller#356 which adds explicit `memiavl_only` overrides to nightly scenario SND templates. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sei-config v0.0.18 defaulted to
memiavl_onlywhich is correct for nightly/main seid but breaks seid v6.5.1 — the stable released version still usescosmos_onlyand rejectsmemiavl_only. Both are deployed simultaneously.Fix
defaults.go: revertWriteModedefault toWriteModeCosmosOnlyin bothStateCommitandStateStore. Default tracks the stable released seid; nightly callers set an explicitmemiavl_onlyoverride.types.go: restorecosmos_only,dual_write,split_writetoIsValid()— required becauseValidate()callsIsValid()on the default value; removing them made a valid v6.5.1 config fail validation.version.json:v0.0.18→v0.0.19The v1→v2 migration still correctly renames
cosmos_only→memiavl_onlyfor upgrade paths.CurrentVersionstays 2.Un-defer condition: bump default back to
memiavl_onlywhen seid v6.6.0 ships with the write mode rename as a tagged release.🤖 Generated with Claude Code