This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Export state analysis data to DynamoDB#101
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 63.60% 63.67% +0.07%
==========================================
Files 28 28
Lines 4047 4047
==========================================
+ Hits 2574 2577 +3
+ Misses 1173 1171 -2
+ Partials 300 299 -1 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+143
to
+145
| for _, contract := range contracts { | ||
| contractSlice = append(contractSlice, *contract) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+219
to
+223
| for _, result := range moduleResults { | ||
| // Create analysis object directly from raw data | ||
| analysis := createStateSizeAnalysis(height, result.ModuleName, result) | ||
| analyses = append(analyses, analysis) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+259
to
+261
| for _, entry := range result.ContractSizes { | ||
| contractSlice = append(contractSlice, *entry) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+291
to
+293
| for _, contract := range result.ContractSizes { | ||
| contractSlice = append(contractSlice, *contract) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
masih
reviewed
Aug 28, 2025
| ValueSizeByPrefix: make(map[string]int64), | ||
| TotalSizeByPrefix: make(map[string]int64), | ||
| NumKeysByPrefix: make(map[string]int64), | ||
| ContractSizes: make(map[string]*utils.ContractSizeEntry), |
Collaborator
There was a problem hiding this comment.
Questions:
- How big can these maps get in terms of memory footprint?
- do we need the exact prefix values or simply their distribution? If latter, hash them to cap the maximum memory footprint?
Collaborator
Author
There was a problem hiding this comment.
These maps are pretty small, there are usually less than 10 different key prefix. Each key prefix is like 2 bytes. We need the exact prefix values, since are pretty small, shouldn't be a big concern, but yeah, this is a good point to think about
blindchaser
approved these changes
Aug 29, 2025
Comment on lines
+226
to
+264
| for moduleName, result := range moduleResults { | ||
| fmt.Printf("Module %s total numKeys:%d, total keySize:%d, total valueSize:%d, totalSize: %d \n", | ||
| result.ModuleName, result.TotalNumKeys, result.TotalKeySize, result.TotalValueSize, result.TotalSize) | ||
|
|
||
| prefixKeyResult, _ := json.MarshalIndent(result.PrefixSizes[moduleName].KeySize, "", " ") | ||
| fmt.Printf("Module %s prefix key size breakdown (bytes): %s \n", result.ModuleName, prefixKeyResult) | ||
|
|
||
| prefixValueResult, _ := json.MarshalIndent(result.PrefixSizes[moduleName].ValueSize, "", " ") | ||
| fmt.Printf("Module %s prefix value size breakdown (bytes): %s \n", result.ModuleName, prefixValueResult) | ||
|
|
||
| totalSizeResult, _ := json.MarshalIndent(result.PrefixSizes[moduleName].TotalSize, "", " ") | ||
| fmt.Printf("Module %s prefix total size breakdown (bytes): %s \n", result.ModuleName, totalSizeResult) | ||
|
|
||
| numKeysResult, _ := json.MarshalIndent(result.PrefixSizes[moduleName].KeyCount, "", " ") | ||
| fmt.Printf("Module %s prefix num of keys breakdown: %s \n", result.ModuleName, numKeysResult) | ||
|
|
||
| // Display top contracts (already limited to top 100) | ||
| fmt.Printf("\nDetailed breakdown for 0x03 prefix (top %d contracts by total size):\n", len(result.ContractSizes)) | ||
| fmt.Printf("%-42s %15s %10s\n", "Contract Address", "Total Size", "Key Count") | ||
| fmt.Printf("%s\n", strings.Repeat("-", 70)) | ||
|
|
||
| // Convert to slice for display | ||
| var contractSlice []utils.ContractSizeEntry | ||
| for _, entry := range result.ContractSizes { | ||
| contractSlice = append(contractSlice, *entry) | ||
| } | ||
|
|
||
| // Sort by total size in descending order for display | ||
| sort.Slice(contractSlice, func(i, j int) bool { | ||
| return contractSlice[i].TotalSize > contractSlice[j].TotalSize | ||
| }) | ||
|
|
||
| for _, contract := range contractSlice { | ||
| fmt.Printf("0x%-40s %15d %10d\n", | ||
| contract.Address, | ||
| contract.TotalSize, | ||
| contract.KeyCount) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR is add support to export state size result to DynamoDB so that we can later expose metrics to do more offline analysis
Testing performed to validate your change
Tested and validated on DynamoDB