Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Upgrade to Go 1.24 and fix all golangci-lint issues#117

Merged
masih merged 6 commits intomainfrom
masih/golangci-lint-unfuck
Oct 7, 2025
Merged

Upgrade to Go 1.24 and fix all golangci-lint issues#117
masih merged 6 commits intomainfrom
masih/golangci-lint-unfuck

Conversation

@masih
Copy link
Copy Markdown
Collaborator

@masih masih commented Oct 7, 2025

The code here needs to be upgraded to the later version of go to pull necessary dependencies. As a result, the very out of date golangci-lint setup and config blocks the PR merges.

Fix all issues, upgrade go mod and golangci-lint config, plus the CI workflow to be consistent with what's used in sei-chain.

masih added 4 commits October 7, 2025 10:36
The code here needs to be upgraded to the later version of go to pull
necessary dependencies. As a result, the very out of date golangci-lint
setup and config blocks the PR merges.

Fix all issues, upgrade go mod and golangci-lint config, plus the CI
workflow to be consistent with what's used in sei-chain.
@masih masih marked this pull request as ready for review October 7, 2025 10:29
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 23.85965% with 217 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.72%. Comparing base (00d174d) to head (c5ac46c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
ss/test/storage_test_suite.go 0.00% 54 Missing ⚠️
ss/pebbledb/db.go 14.70% 25 Missing and 4 partials ⚠️
sc/memiavl/snapshot.go 56.25% 9 Missing and 5 partials ⚠️
sc/memiavl/import.go 27.77% 8 Missing and 5 partials ⚠️
tools/utils/utils.go 0.00% 11 Missing ⚠️
tools/bench/benchmark.go 0.00% 10 Missing ⚠️
sc/store.go 0.00% 9 Missing ⚠️
tools/cmd/seidb/operations/state_size.go 0.00% 9 Missing ⚠️
sc/memiavl/multitree.go 65.21% 3 Missing and 5 partials ⚠️
stream/changelog/utils.go 20.00% 8 Missing ⚠️
... and 18 more

❌ Your patch status has failed because the patch coverage (23.85%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (39.72%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #117       +/-   ##
===========================================
- Coverage   64.08%   39.72%   -24.36%     
===========================================
  Files          28       58       +30     
  Lines        4057     7481     +3424     
===========================================
+ Hits         2600     2972      +372     
- Misses       1161     4162     +3001     
- Partials      296      347       +51     
Files with missing lines Coverage Δ
sc/memiavl/mmap.go 75.86% <100.00%> (ø)
sc/memiavl/node.go 73.43% <ø> (ø)
ss/rocksdb/db.go 44.77% <0.00%> (ø)
tools/cmd/seidb/benchmark/iteration.go 0.00% <0.00%> (ø)
tools/cmd/seidb/benchmark/random_read.go 0.00% <0.00%> (ø)
tools/cmd/seidb/benchmark/reverse_iteration.go 0.00% <0.00%> (ø)
tools/cmd/seidb/benchmark/write.go 0.00% <0.00%> (ø)
tools/cmd/seidb/operations/replay_changelog.go 0.00% <0.00%> (ø)
sc/memiavl/proof.go 89.36% <71.42%> (-1.15%) ⬇️
ss/util/xor_hasher.go 0.00% <0.00%> (ø)
... and 20 more

... and 15 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread sc/memiavl/multitree.go Outdated
Comment thread sc/memiavl/snapshot.go
Comment thread stream/changelog/utils.go
Comment thread sc/memiavl/multitree.go Outdated
Comment thread ss/pebbledb/comparator.go
@yzang2019
Copy link
Copy Markdown
Collaborator

LGTM! Thanks for fixing all these!

@masih masih enabled auto-merge (squash) October 7, 2025 18:48
@masih masih removed request for Kbhat1 and blindchaser October 7, 2025 19:05
seems to be stuck on pending response
@masih
Copy link
Copy Markdown
Collaborator Author

masih commented Oct 7, 2025

Strange. The golangci lint passed but github actions status doesn't seem to have been picked up: https://github.com/sei-protocol/sei-db/actions/runs/18323479032

@masih masih merged commit 1641349 into main Oct 7, 2025
11 of 15 checks passed
@masih masih deleted the masih/golangci-lint-unfuck branch October 7, 2025 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants