Skip to content

Conversation

@dssei
Copy link
Contributor

@dssei dssei commented Sep 9, 2025

  • Update x402 to use coinbase x402 packages since Sei is officially supported by x402
  • Update all code examples

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: 6921b53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.29%. Comparing base (0dc3751) to head (6921b53).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   79.29%   79.29%           
=======================================
  Files          82       82           
  Lines        1280     1280           
  Branches      212      212           
=======================================
  Hits         1015     1015           
  Misses        259      259           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@alexander-sei alexander-sei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://linear.app/seilabs/issue/REL-34/bug-in-sei-js-tutorial missing here, it still has npm in all tutorials

@dssei
Copy link
Contributor Author

dssei commented Sep 11, 2025

https://linear.app/seilabs/issue/REL-34/bug-in-sei-js-tutorial missing here, it still has npm in all tutorials

Which one do we want as a default? NPM worked for me, but I did not test in monorepos though. Do we want to remove it completely?

@dssei
Copy link
Contributor Author

dssei commented Sep 11, 2025

https://linear.app/seilabs/issue/REL-34/bug-in-sei-js-tutorial missing here, it still has npm in all tutorials

Which one do we want as a default? NPM worked for me, but I did not test in monorepos though. Do we want to remove it completely?

Made pnpm the default option

@Shreyas-sei
Copy link

Shreyas-sei commented Sep 11, 2025

Pnpm is good but yarn would be more recommendable as default

@dssei dssei requested a review from alexander-sei September 12, 2025 15:38
@dssei dssei merged commit 91a3e9c into main Sep 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants