fix(noderesource): forward auth headers from kube-rbac-proxy to sidecar#275
Merged
Conversation
Add --auth-header-fields-enabled=true to the kube-rbac-proxy args so the proxy emits X-Remote-User after successful TokenReview + SAR. The sidecar runs in trusted-header authn mode (SEI_SIDECAR_AUTHN_MODE =trusted-header) and rejects upstream-forwarded requests that lack this header with 401. Applied to both the SeiNode StatefulSet proxy and the bootstrap pod proxy.
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
bdchatham
added a commit
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `--auth-header-fields-enabled=true` to the kube-rbac-proxy args so the proxy emits `X-Remote-User` after a successful TokenReview + SAR. The sidecar runs in `trusted-header` authn mode and rejects any upstream-forwarded request that lacks this header with 401.
How it surfaced
After PR #274 fixed the `apiGroup` field name, the smoke test progressed past the proxy's SAR check — and immediately tripped the sidecar's authn:
`--auth-header-fields-enabled` defaults to `false` in kube-rbac-proxy v0.19.x. With it off, the proxy authorizes successfully but forwards a bare request — the sidecar then has no way to know which identity passed auth, so it rejects.
Scope
Both proxy instances need the flag; the bootstrap pod uses the same sidecar trusted-header authn path.
Test plan
🤖 Generated with Claude Code