fix: restore configure-state-sync for S3 snapshot restores#72
Merged
Conversation
Reverts the logic change from #62 that skipped configure-state-sync for S3 snapshot sources. The original rationale assumed S3 snapshot-restore writes a complete data directory, but the sidecar extracts ABCI snapshot chunks to data/snapshots/. Without configure-state-sync (useLocalSnapshot: true), CometBFT starts with statesync.enable=false, never applies the snapshot, and panics at InitChain with an empty state DB. Restores the original guard (`snap != nil`) so configure-state-sync runs for both S3 and StateSync sources. Fixes the pacific-1-shadow-replayer canonicalRpc port typo (2665 → 26657). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the logic change from #62 that skipped
configure-state-syncfor S3 snapshot sources.snapshot-restorewrites a complete data directory (app.db, blockstore, state), soconfigure-state-syncwas unnecessarydata/snapshots/— CometBFT needsstatesync.enable=truewithuseLocalSnapshotto apply themconfigure-state-sync, seid starts with an empty state DB, hitsInitChain, and panics inDeliverGenTxsWhat changed
snap != nil) in bothbuildBasePlanandbuildBootstrapProgressionsoconfigure-state-syncruns for S3 and StateSync sourcesconfigure-state-syncin S3 snapshot planscanonicalRpcport typo (2665 → 26657)Observed failure
pacific-1-shadow-replayerbootstrap pod panicked:All sidecar tasks completed (snapshot-restore, genesis, config, peers, validate, mark-ready) but seid found
LastBlockHeight=0because the ABCI snapshot chunks were never applied.Test plan
go test ./internal/...— all plan progression and integration tests pass🤖 Generated with Claude Code