-
Notifications
You must be signed in to change notification settings - Fork 2
feat(observability): OTel instrumentation + HTTP idle-pool options #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bdchatham
wants to merge
13
commits into
main
Choose a base branch
from
feat/scale-idle-pool-with-workers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d626589
refactor(sender): configurable HTTP idle-conn pool with defaults 500/50
bdchatham bb74d4d
sender: drop implicit worker-derived override, rely on 500/50 defaults
bdchatham 1c9aae4
feat(observability): OTel instrumentation for platform deployments
bdchatham 7ef439a
observability: enable OpenMetrics + fix shutdown order + trim cardina…
bdchatham c4ba0c6
observability: drop bespoke OnceValue wrappers for idiomatic OTel
bdchatham 057330e
observability: bump otelhttp v0.54.0 -> v0.68.0
bdchatham ef14cd4
observability: trim comments, move invariants to README
bdchatham ca5b8ee
ci: bump Go to 1.25.1 + golangci-lint to v2.1.6
bdchatham 2ba94e4
ci: golang:1.25.1-bookworm (bullseye variant not published for Go 1.25)
bdchatham 0002e56
ci: golangci-lint-action @v7 (v6 doesn't support golangci-lint v2.x)
bdchatham 0b22e5d
ci: golangci-lint version latest (v2.1.6 still built on Go 1.24)
bdchatham 16d3027
lint: fix issues surfaced by golangci-lint v2
bdchatham 95fe37c
review: address amir-deris feedback on PR #28
bdchatham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM golang:1.24.5-bullseye AS build | ||
| FROM golang:1.25.1-bookworm AS build | ||
|
|
||
| WORKDIR /go/src/sei-load | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.