fix: use DownloadObject to avoid transfer manager concurrentReader panic#29
Merged
fix: use DownloadObject to avoid transfer manager concurrentReader panic#29
Conversation
…r panic The transfer manager GetObject streaming API (concurrentReader) has a bounds-check bug in v0.1.x that causes a panic during large S3 downloads. Switch to DownloadObject (io.WriterAt path) which downloads byte-range chunks in parallel to a temp file, then streams extraction from disk. Also upgrades aws-sdk-go-v2 modules to latest and moves S3GetObjectAPI types to genesis.go (the only remaining consumer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concurrentReaderthat has a bounds-check bug in v0.1.x, causing panics during large S3 snapshot downloads:slice bounds out of range [30775:12064]io.WriterAtpath) which downloads byte-range chunks in parallel to a temp file, then streams through gzip+tar extraction — same throughput, noconcurrentReaderinvolvementS3TransferClientinterface (justDownloadObject) for snapshot restore; movesS3GetObjectAPI/S3ClientFactorytogenesis.go(the only remaining consumer)writeAtBufferhelper for downloading small files (e.g. latest.txt) in-memory viaDownloadObjectTest plan
DownloadObject-based)TestSnapshotRestoreCleansUpTempFilevalidates no leftover temp filesgolangci-lintandgofmtclean