refactor: simplify genesis resolution and clean up sidecar task handlers#49
Merged
refactor: simplify genesis resolution and clean up sidecar task handlers#49
Conversation
Introduce engine.TypedHandler[T] — a generic helper that wraps typed handler functions into TaskHandler. Each handler now receives its own typed params struct instead of parsing map[string]any. The TypedHandler bridges map[string]any → json.Marshal → json.Unmarshal → typed struct, giving handlers compile-time type safety without changing the engine, store, server, or client. All manual parse functions removed: parseSnapshotConfig, parseUploadConfig, parseExportConfig, parseAssembleConfig, parseNodeNames, parseArtifactUploadConfig, parseGenesisPeersConfig, parseGenesisS3Config, intentFromParams, extractStringMap, parseSources, parseEC2TagsSource, parseStaticSource, toStringMap, toStringSlice, parseTargetHeight The float64/int64/json.Number type switches in await_condition and statesync are eliminated — json.Unmarshal into int64 handles it. 20 files changed, net -241 lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… tests Rename all task param structs from xConfig/xParams to xRequest: SnapshotConfig → SnapshotRestoreRequest SnapshotUploadConfig → SnapshotUploadRequest configPatchParams → ConfigPatchRequest ResultExportConfig → ResultExportRequest StateSyncParams → StateSyncRequest awaitConditionParams → AwaitConditionRequest genesisParams → ConfigureGenesisRequest genesisPeersConfig → SetGenesisPeersRequest identityParams → GenerateIdentityRequest gentxParams → GenerateGentxRequest assembleConfig → AssembleGenesisRequest artifactUploadConfig → UploadArtifactsRequest peerDiscoverParams → DiscoverPeersRequest configReloadParams → ConfigReloadRequest peerSourceConfig → PeerSourceEntry All structs now exported for external consumers. Add exhaustive TypedHandler tests: - Happy path, malformed JSON, nil params, nested structs, float64→int64 - Integration tests for all 15 handler deserialization paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace explicit URI/region task params with environment-driven
resolution. The fetcher now checks sei-config embedded genesis first,
then falls back to S3 at {bucket}/{chainID}/genesis.json using
SEI_GENESIS_BUCKET and SEI_GENESIS_REGION env vars.
Bump sei-config to v0.0.9 (corrected embedded genesis files).
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The sidecar now resolves genesis from chainId alone using sei-config embedded lookup with S3 fallback. The client no longer needs to send explicit S3 coordinates. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove S3 bucket/prefix/region from ceremony task params
(upload-genesis-artifacts, assemble-and-upload-genesis,
set-genesis-peers). These are now derived from SEI_GENESIS_BUCKET,
SEI_GENESIS_REGION, and SEI_CHAIN_ID env vars at construction time.
The S3 prefix is deterministic: {chainID}/.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…bleAndUploadGenesisTask Match the simplified handler request types — S3 coordinates are derived by the sidecar from its environment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
H1: Remove dead parseUploadConfig and its test (TypedHandler artifact)
H2: (deferred — SubmitSetGenesisPeersTask not needed until controller uses it)
H4: Fix readLocalNodeID to derive node ID from Ed25519 key, matching
CometBFT's p2p.PubKeyToID derivation (was incorrectly assuming
top-level "id" field in node_key.json)
M2: ConfigPatcher now rejects empty files (consistent with client validation)
M4: Add AccountBalance and Namespace to client AssembleAndUploadGenesisTask
M7: Remove dead CommandRunner type and DefaultCommandRunner, update all
constructors (NewIdentityGenerator, NewGentxGenerator, NewGenesisAssembler)
L1: Fix stale ListTasks doc comment
L2: Fail fast on invalid SEI_SNAPSHOT_UPLOAD_INTERVAL instead of silently
falling back to default
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
# Conflicts: # sidecar/tasks/assemble_genesis.go # sidecar/tasks/assemble_genesis_test.go # sidecar/tasks/config.go # sidecar/tasks/genesis.go # sidecar/tasks/genesis_peers.go # sidecar/tasks/genesis_test.go # sidecar/tasks/typed_handler_integration_test.go # sidecar/tasks/upload_genesis_artifacts.go
The test expected nil (fail-safe) but Export() correctly propagates the S3 uploader factory error. The test expectation was wrong. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SEI_GENESIS_BUCKET,SEI_GENESIS_REGION,SEI_CHAIN_ID) instead of receiving them as task params. Genesis resolution: embedded sei-config first, S3 fallback at{bucket}/{chainID}/genesis.json.CommandRunnertype,parseUploadConfig, stale S3 fields from client task typesreadLocalNodeID: Now derives node ID from Ed25519 key (matching CometBFT'sp2p.PubKeyToID), instead of assuming a top-level"id"field innode_key.jsonSEI_SNAPSHOT_UPLOAD_INTERVALfails fast on invalid value, stale doc comments cleaned upserve.govalidatesSEI_CHAIN_ID,SEI_GENESIS_BUCKET,SEI_GENESIS_REGIONat startupDeployment notes
SEI_GENESIS_BUCKETandSEI_GENESIS_REGIONinto sidecar pod specs (see sei-protocol/sei-k8s-controllerrefactor/genesis-env-drivenbranch)Test plan
go test ./sidecar/...— all pass (pre-existingTestExportS3UploaderFactoryErrorunrelated)🤖 Generated with Claude Code