refactor: environment-driven snapshot upload#53
Merged
Conversation
Move S3 bucket/region/prefix from task params to sidecar environment,
matching the snapshot restore and genesis conventions. The upload
prefix is now {chainID}/, derived from SEI_CHAIN_ID.
- SnapshotUploadRequest: remove Bucket/Prefix/Region
- NewSnapshotUploader: takes bucket/region/chainID from env
- Client SnapshotUploadTask: stripped to empty (no params)
- Upload and runLoop use struct fields instead of request params
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move snapshot upload S3 coordinates from task params to sidecar environment, matching the snapshot restore and genesis conventions.
SnapshotUploadRequest: remove Bucket/Prefix/Region (now empty)NewSnapshotUploader: takes bucket/region/chainID from env at construction{chainID}/fromSEI_CHAIN_IDSnapshotUploadTaskstripped to empty structCompanion PR
Test plan
🤖 Generated with Claude Code