fix: export-state memory and gentx error handling#54
Merged
Conversation
bdchatham
commented
Apr 2, 2026
|
|
||
| s3Objects := &mockS3GetObject{objects: map[string][]byte{ | ||
| "pacific-1/exported-state.json": []byte(exportedGenesis), | ||
| "test-group/pacific-1/exported-state.json": []byte(exportedGenesis), |
Contributor
Author
There was a problem hiding this comment.
I'm not positive why we need group in the S3 location
- Stream seid export stdout directly to temp file instead of holding multi-GB output in memory. Upload reads from the file on disk. - Surface errors for unparseable gentx files in addMissingGenesisAccounts instead of silently skipping them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bdchatham
force-pushed
the
fix/fork-export-review-fixes
branch
from
9331743 to
8dab2c9
Compare
bdchatham
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seid exportstdout directly to a temp file instead of capturing multi-GB output in memory viacmd.Output(). The S3 upload now reads from disk. Prevents OOM on production chain exports.addMissingGenesisAccountsnow returns errors for unreadable/unparseable gentx files instead of silently skipping them. Makes failures visible at the point of failure rather than surfacing as confusing errors incollectGentxs.Test plan
go build ./...clean🤖 Generated with Claude Code