Skip to content

chore: update gorelease to fix nil pointer panic on Go 1.26#24

Merged
bdchatham merged 1 commit intomainfrom
chore/update-gorelease
Mar 9, 2026
Merged

chore: update gorelease to fix nil pointer panic on Go 1.26#24
bdchatham merged 1 commit intomainfrom
chore/update-gorelease

Conversation

@bdchatham
Copy link
Copy Markdown
Contributor

@bdchatham bdchatham commented Mar 9, 2026

Summary

  • Update pinned gorelease commit from f062dba to 3dfff04 in release-check.yml
  • The old commit pulls in golang.org/x/tools@v0.2.0 which has a nil pointer dereference in go/types.(*StdSizes).Sizeof when run under Go 1.26+
  • The new commit depends on golang.org/x/tools@v0.42.0 which is compatible with current Go versions

Context

This was discovered when the seilog repo's release check workflow panicked during a version bump PR. The stack trace showed gorelease crashing in go/types type-checking due to the old x/tools dependency being incompatible with the Go 1.26.1 runtime on CI runners.

The pinned gorelease commit (f062dba) pulls in golang.org/x/tools@v0.2.0
which has a nil pointer dereference in go/types.(*StdSizes).Sizeof when
run under Go 1.26. Update to the latest exp commit (3dfff04) which
depends on golang.org/x/tools@v0.42.0.
@bdchatham bdchatham requested review from masih and mojtaba-esk March 9, 2026 16:53
@bdchatham bdchatham merged commit 13fdb52 into main Mar 9, 2026
@bdchatham bdchatham deleted the chore/update-gorelease branch March 9, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants