Skip to content

Conversation

@Dimi1010
Copy link
Collaborator

Changes:

  • PointerVector's front(), back() and at() changed to return T* even in const on the rationale that modifying the pointee does not modify the vector's contents (the pointer in the vector isn't modified).
  • Updated DpdkDeviceList to use internal::DeviceListBase.

…is `const` as modifications to the pointee object would not modify the vector itself.
@codecov
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (964eab7) to head (0a18b5c).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
Common++/header/PointerVector.h 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1796      +/-   ##
==========================================
- Coverage   83.06%   83.04%   -0.02%     
==========================================
  Files         284      284              
  Lines       48980    48977       -3     
  Branches    10528    10346     -182     
==========================================
- Hits        40684    40675       -9     
- Misses       7516     7650     +134     
+ Partials      780      652     -128     
Flag Coverage Δ
alpine320 75.04% <100.00%> (+<0.01%) ⬆️
fedora42 75.10% <100.00%> (-0.03%) ⬇️
macos-13 80.58% <66.66%> (-0.01%) ⬇️
macos-14 80.57% <66.66%> (-0.02%) ⬇️
macos-15 80.55% <66.66%> (-0.01%) ⬇️
mingw32 70.64% <100.00%> (-0.04%) ⬇️
mingw64 70.60% <100.00%> (-0.04%) ⬇️
npcap 84.93% <ø> (-0.10%) ⬇️
rhel94 74.92% <100.00%> (+0.02%) ⬆️
ubuntu2004 58.53% <100.00%> (-0.02%) ⬇️
ubuntu2004-zstd 58.62% <100.00%> (-0.03%) ⬇️
ubuntu2204 74.81% <100.00%> (-0.04%) ⬇️
ubuntu2204-icpx 61.47% <66.66%> (-0.01%) ⬇️
ubuntu2404 75.06% <100.00%> (-0.03%) ⬇️
ubuntu2404-arm64 75.06% <100.00%> (-0.01%) ⬇️
unittest 83.04% <66.66%> (-0.02%) ⬇️
windows-2019 85.02% <ø> (-0.03%) ⬇️
windows-2022 85.04% <ø> (-0.02%) ⬇️
winpcap 85.18% <ø> (-0.01%) ⬇️
xdp 50.53% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review April 30, 2025 10:36
@Dimi1010 Dimi1010 requested a review from seladb as a code owner April 30, 2025 10:37
@Dimi1010 Dimi1010 merged commit 28dc27d into seladb:dev May 2, 2025
43 checks passed
@Dimi1010 Dimi1010 deleted the refactor/dpdk-dev-list-base branch May 2, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants