Skip to content

Fixed #192 Reading file content #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RameshBabuPrudhvi merged 3 commits into from
Oct 14, 2022
Merged

Fixed #192 Reading file content #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d63cfb4
Fixed #192 Reading file content
RameshBabuPrudhvi Oct 13, 2022
d5c4534
Skip Test
RameshBabuPrudhvi Oct 13, 2022
360feff
Assert just before calling AfterTest
RameshBabuPrudhvi Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion selcukes-commons/src/main/java/io/github/selcukes/commons/helper/FileHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public String downloadToUsersFolder(final String url) {
*/
public String readContent(final String filePath) {
try {
return Files.readString(loadThreadResource(filePath).toPath());
return new String(loadResourceFromJar(filePath).readAllBytes(), StandardCharsets.UTF_8);
} catch (Exception e) {
throw new SelcukesException(String.format("Cannot load [%s] from classpath", filePath));
}
Expand Down
6 changes: 5 additions & 1 deletion selcukes-core/src/main/java/io/github/selcukes/core/listener/ResourceCleanupProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,14 @@ public void beforeTest(TestResult result) {
logger.debug(() -> "Before invocation of " + result.getName());
}

@Override
public void beforeAfterTest(TestResult result) {
Validation.failAll();
}

@Override
public void afterTest(TestResult result) {
logger.debug(() -> "Cleanup Test Resource...");
Validation.failAll();
DriverFixture.removeDriverFixture();
DriverManager.removeDriver();
ConfigFactory.cleanupConfig();
Expand Down
2 changes: 1 addition & 1 deletion selcukes-core/src/test/java/io/github/selcukes/core/tests/web/PrintTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ public void setup() {
@Test
public void testPrint() {
page.open("https://techyworks.blogspot.com/2022/03/get-browser-session-storage-data-using-selenium.html");
page.printPage("target/print.pdf");
// page.printPage("target/print.pdf");
}
}