Fixups: post-merge updates related to PR #6241#6335
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
QUnit.test instead of relying on global namespace entry|
@kevin-brown something about the |
|
The problem seems to be that
I attempted to add a The second approach doesn't appear straightforward either; there is no ...so I've slightly-reluctantly implemented the third approach. It doesn't genuinely provide any meaningful runtime isolation between the integration test cases, but it ensure that each event listener should only perform any actions within the scope of its parent test case. |
|
@kevin-brown it's not ideal code (details in my previous message if you're curious), but I believe this is ready for merge. |
|
I'll take the "temporary" hack for now. Thanks for looking into this and documenting your findings! |
- Remove '(unreleased)' marker from the 4.1.0 heading - Add new features: jQuery 4.0.0 support (#6332), originalEvent in close trigger args (#6079) - Add bug fixes: placeholder misalignment (#6277), RTL choice remove button (#6257), digit-only data-placeholder (#6297), AJAX unselection with non-string IDs (#6241, #6335), optgroup child string coercion (#6338) - Add translations: lb (#6131), ug (#6166), ar (#6175), zh-TW (#6157), id (#6153), tr (#6123), ro (#6190), de/es/fr/pt/pt-BR (#6132), pl (#6097, #6377), nb (#6213), fa (#6258), nl (#6269), pt-BR typo (#6200), missing bs/ca/da/fi strings (#6305) - Add miscellaneous: native DOM replacements for jQuery attr/removeAttr (#6227, #6228), classList.add (#6229), jQuery removal from Utils and Translation (#6233), prop() removal (#6289), NPM trusted publishing (#6405)
This pull request includes a
The following changes were made
testin an integration test added by Fixup: unselection of items from AJAX data sources with non-string identifiers #6241, use the fully-qualified referenceQUnit.testinstead, as becomes standard after Dependencies/CI: updates to prepare for jQuery 4.0.0-beta testing #6334.selection:updateevent handlers in the integration tests, because these are not isolated from each other at test runtime, and otherwise may delay/timeout unrelated test cases.If this is related to an existing ticket, include a link to it as well.
Relates-to / merge-resolution-for #6241 and #6334.
Edit: add additional fixup descriptions.