Adding ability to use load to init opt groups #1279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 1e9828e on brainded:master into ** on selectize:master**. |
|
Hi, any prediction on if this will be merged and if so, when? Seems like a great addition for the project! Kind regards and thanks again for making selectize so great! |
|
It would be great if this could be merged. |
|
I'd need that. Has this not gotten merged yet? Is there another good alternative? |
oyejorge
added a commit
to orchidjs/tom-select
that referenced
this pull request
Sep 18, 2020
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the ability to init the list from a async source was missing the ability to also init groups, so I added what I thought was needed to get this working. It utilizes the optgroupValueField to figure out the Id to use with the addOptionGroup method and iterates through the list of groups to add them.
I looked for any examples of tests for the load function but didn't find any. I am going to take a look at adding a test once I figured out how to use this testing pattern with the function but I wanted to get this pull request open so its at least on the board.