Docker File update #108
Merged
Docker File update #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Shell script files which are present are to be made executable post copying to keep them ready for any executions on fly
Dockerfile defaults should be executable ready
Member
|
@surevs Merged, although those files should already be executable by default. It can't hurt to make sure that they're executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael,
This is a proposal to make the shell scripts executable on Dockerfile during the docker build process itself to ease the way we are trying to call the files and keep them ready for any demo.
You may please advise in case of any other thoughts.
Regards,
Revant