Skip to content

Browser version caps #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adityai wants to merge 2 commits into from
Closed

Browser version caps #2288

adityai wants to merge 2 commits into from

Conversation

@adityai
Copy link

@adityai adityai commented Nov 15, 2023

Trying to address the issue reported here: #2287

@mdmintz
Copy link
Member

mdmintz commented Nov 16, 2023

  1. You didn't test your code, as this TYPO would've broken seleniumbase for all users:
Screenshot 2023-11-15 at 9 26 36 PM

  1. You shouldn't be setting the version in your PR. (I set the version in a special way after all tickets are in.)

  2. Your changes didn't cover all areas that needed to be covered for this. (I ended up creating another PR for fixing the main ticket you opened.)

@mdmintz mdmintz closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adityai @mdmintz