Skip to content

Conversation

@jimmy927
Copy link

locale_code should set lang instead of just intl.accept_languages

@mdmintz
Copy link
Member

mdmintz commented Oct 23, 2024

Both https://stackoverflow.com/a/11375463/7058266 and https://stackoverflow.com/a/55254431/7058266 say that using intl.accept_languages is the correct way to do it. I see no effect with the --lang arg. Can you show me a full example where adding the arg changed website behavior with SeleniumBase?

@jimmy927
Copy link
Author

Both https://stackoverflow.com/a/11375463/7058266 and https://stackoverflow.com/a/55254431/7058266 say that using intl.accept_languages is the correct way to do it. I see no effect with the --lang arg. Can you show me a full example where adding the arg changed website behavior with SeleniumBase?

My code:

Driver(lang="en_us")

With my patch i get english, without my patch i get swedish (which is the locale of the local windows)
Maybe this is different on different os ?

Chrome 130, Windows 10

@mdmintz
Copy link
Member

mdmintz commented Oct 23, 2024

I need to see a full example script, with a real website. Not partial code.

@jimmy927
Copy link
Author

sorry, no time.
Just throw it away if you like.

@mdmintz mdmintz closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants