Fixing Unicode error and other stuff#2
Merged
seletskiy merged 7 commits intoseletskiy:masterfrom Jul 3, 2015
Merged
Conversation
First error happens upon launch. `unichr()` can't accept values for multimedia keys, as they are outside the Unicode range. Second error happens when trying to set a label to a string containing null characters.
Mostly whitespace. Also moved GTK/GDK threading initialization to inside main().
Owner
|
@denilsonsa: wow, thanks! Will merge soon. |
Owner
There was a problem hiding this comment.
I guess there should be if not ..., because ps will return 0 code if process exist.
seletskiy
added a commit
that referenced
this pull request
Jul 3, 2015
Fixing Unicode error and other stuff
Author
|
Yeah, I inverted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing unicode error upon launch (also fixed in elecnix/screenkey@5c362f2, but using a different logic).
Other minor cleanup, mostly whitespace (add
?w=1to GitHub URLs to ignore whitespace when viewing the diffs) and code styling (with help of pep8 tool).