Conversation
Owner
Author
|
Figure out how to handle "double newline". When a block appears right after a newline, a redundant newline is inserted between the actual newline, and the one created by |
Owner
Author
|
Trimming whitespace seems to work. Another problem, when we preserve text whitespace, indentation is all wrong due to margins/padding. Maybe disabling them, and adding the previous whitespace of each Tree, to the Tree, will work? |
Owner
Author
|
Maybe boxes aren't the way to go here? Can we just copy how the text appears in the real file, and draw boxes dynamically around relevant parts? For example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.