-
Notifications
You must be signed in to change notification settings - Fork 2
[#11] feat: Establish discovery system and add support for /areas #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request establishes a discovery system for ROS 2 nodes and namespaces, introducing the GET /areas REST API endpoint. The gateway automatically discovers nodes in the ROS 2 system, organizes them into areas based on their namespace hierarchy, and exposes this information through a RESTful HTTP interface.
Key Changes:
- Implemented DiscoveryManager to discover and organize ROS 2 nodes into areas and components
- Added GET /areas endpoint to list discovered areas (e.g., powertrain, chassis, body)
- Created demo automotive nodes in proper namespaces for testing
- Added comprehensive integration tests and Postman collections
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/gateway_node.cpp |
Refactored from monolithic implementation to modular architecture with discovery and REST server managers |
src/rest_server.cpp |
New REST server implementation with /health, /, and /areas endpoints |
src/discovery_manager.cpp |
New discovery system that extracts areas from ROS 2 node namespaces |
include/ros2_medkit_gateway/*.hpp |
Header files defining gateway architecture with thread-safe entity cache |
test/test_integration.test.py |
Integration tests verifying area discovery and REST API functionality |
test/demo_nodes/*.cpp |
Seven demo automotive nodes simulating sensors, actuators, and services |
launch/gateway.launch.py |
Launch file with configurable parameters for gateway server |
launch/demo_nodes.launch.py |
Launch file organizing demo nodes into automotive areas |
config/gateway_params.yaml |
Configuration file with server and cache refresh parameters |
CMakeLists.txt |
Build configuration for gateway, demo nodes, and integration tests |
package.xml |
Updated dependencies for new functionality |
README.md |
Comprehensive documentation of features, configuration, and usage |
postman/* |
Postman collection and environment for manual API testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ros2_medkit_gateway/include/ros2_medkit_gateway/discovery_manager.hpp
Show resolved
Hide resolved
a83fb1c to
297dd2b
Compare
…areas network endpoint - new endpoint GET /areas - Discovery manager for ROS 2 nodes/namespaces - demo automotive nodes in proper namespaces - integration tests + postman configuration files - Configuration, launch files, documentation - plantum class diagrams
53a6173 to
44f9ee2
Compare
bburda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
[#11] feat: Establish discovery system and add support for /areas network endpoint
Pull Request
Description
What changed and why.
Type of change
Related issues
Fixes # (if applicable)
Related to # (if applicable)
How has this been tested?
Describe the tests you ran to verify your changes.
Checklist
colcon buildand the build succeeds without warningscolcon testand all tests pass locallyAdditional notes for reviewers