fix: use ros2_medkit_cmake package instead of copying cmake dir#39
Merged
fix: use ros2_medkit_cmake package instead of copying cmake dir#39
Conversation
The shared cmake modules are now a proper ament package (ros2_medkit_cmake) instead of a loose cmake/ directory. Replace `cp -r ros2_medkit/cmake` with `mv ros2_medkit/src/ros2_medkit_cmake .` in all Dockerfiles. See: selfpatch/ros2_medkit#295
There was a problem hiding this comment.
Pull request overview
Updates the demo container build flow to consume ros2_medkit’s shared CMake modules via the new ros2_medkit_cmake ament package, instead of copying a cmake/ directory into the workspace.
Changes:
- Replace copying
ros2_medkit/cmakeinto${COLCON_WS}with movingros2_medkit/src/ros2_medkit_cmakeinto the colcon workspace source tree. - Apply the change consistently across all three demo Docker images (sensor diagnostics, TurtleBot3 integration, MoveIt pick/place).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
demos/sensor_diagnostics/Dockerfile |
Moves ros2_medkit_cmake into ${COLCON_WS}/src during image build. |
demos/turtlebot3_integration/Dockerfile |
Moves ros2_medkit_cmake into ${COLCON_WS}/src during image build. |
demos/moveit_pick_place/Dockerfile |
Adds ros2_medkit_cmake to the set of ros2_medkit packages moved into ${COLCON_WS}/src. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mfaferek93
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all 3 demo Dockerfiles to use the new
ros2_medkit_cmakeament package instead of manually copying thecmake/directory.Type
Changes
Replace
cp -r ros2_medkit/cmake ${COLCON_WS}/withmv ros2_medkit/src/ros2_medkit_cmake .in:demos/sensor_diagnostics/Dockerfiledemos/turtlebot3_integration/Dockerfiledemos/moveit_pick_place/DockerfileDependencies
Requires selfpatch/ros2_medkit#295 to be merged first.