fix: update VersionInfo type for gateway sovd_info->items rename#40
Merged
fix: update VersionInfo type for gateway sovd_info->items rename#40
Conversation
The gateway (PR #258) renamed the GET /version-info response key from sovd_info to items for SOVD alignment. Update the web UI types and consumers to match.
There was a problem hiding this comment.
Pull request overview
Updates the web UI to match the gateway’s GET /version-info response shape after the sovd_info key was renamed to items, ensuring server/version information displays correctly in the UI.
Changes:
- Renamed
VersionInfo.sovd_infotoVersionInfo.itemsin the shared TypeScript API types. - Updated Zustand store extraction logic to read
versionInfo?.items?.[0]. - Updated
ServerInfoPanelto readversionInfo?.items?.[0].
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/lib/types.ts |
Renames the VersionInfo response field to items to match the updated gateway contract. |
src/lib/store.ts |
Updates server/version extraction to use items when building the server node info. |
src/components/ServerInfoPanel.tsx |
Updates the server info UI to display version/vendor info from items. |
mfaferek93
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
The gateway (PR selfpatch/ros2_medkit#258) renamed
GET /version-inforesponse key fromsovd_infotoitemsfor SOVD alignment. This updates the web UI TypeScript types and all consumers to match.Changes:
VersionInfo.sovd_info->VersionInfo.itemsintypes.tsstore.tsaccess pattern:versionInfo?.sovd_info?.[0]->versionInfo?.items?.[0]ServerInfoPanel.tsxaccess patternIssue
Type
Testing
npm run typecheckpassesChecklist
npm run lint)npm run build)