fix: build dashboard SPA in CI/publish and lead install with npm proof path#46
Closed
WellDunDun wants to merge 1 commit intodevfrom
Closed
fix: build dashboard SPA in CI/publish and lead install with npm proof path#46WellDunDun wants to merge 1 commit intodevfrom
WellDunDun wants to merge 1 commit intodevfrom
Conversation
…f path The publish workflow was missing the dashboard SPA build step, so the published package never included apps/local-dashboard/dist/. CI now also verifies the SPA builds on every PR. README install section leads with `npx selftune@latest doctor` as the primary proof command. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a new CI job to build a dashboard and integrates dashboard building into the publish workflow. Updates README installation instructions to recommend skill-based installation instead of CLI-only approach. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 33-36: The phrase "One command to install and verify" is
misleading because `npx selftune@latest doctor` runs the package temporarily;
update the README sentence that follows the `npx selftune@latest doctor` example
to indicate this is a verification/test run rather than a permanent install
(e.g., change to "One command to verify your setup" or add "runs via npx without
persisting install"), and optionally add a short pointer mentioning the actual
installation method referenced later (the skill-based approach) so readers know
where to go for a persistent install.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0e180578-50c8-4b50-b673-2effe2b32d3e
📒 Files selected for processing (3)
.github/workflows/ci.yml.github/workflows/publish.ymlREADME.md
Comment on lines
+33
to
+36
| npx selftune@latest doctor | ||
| ``` | ||
|
|
||
| Then tell your agent: **"initialize selftune"** | ||
| That's it. One command to install and verify. Then tell your agent: **"initialize selftune"** |
There was a problem hiding this comment.
Wording may mislead users about installation.
Line 36 says "One command to install and verify" but npx selftune@latest doctor runs the package temporarily via npx without persisting it. The actual installation for Claude Code users is the skill-based approach on line 43. Consider rewording to something like "One command to verify your setup" or clarifying that this tests the npm package without permanent installation.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 33 - 36, The phrase "One command to install and
verify" is misleading because `npx selftune@latest doctor` runs the package
temporarily; update the README sentence that follows the `npx selftune@latest
doctor` example to indicate this is a verification/test run rather than a
permanent install (e.g., change to "One command to verify your setup" or add
"runs via npx without persisting install"), and optionally add a short pointer
mentioning the actual installation method referenced later (the skill-based
approach) so readers know where to go for a persistent install.
Collaborator
Author
|
Closing as superseded — all three changes in this PR are already on
No replacement PR needed. Thanks for the contribution — the intent shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens the release/install path to prove the published package behaves like the branch code.
Changes:
bun run build:dashboard) beforenpm publish, so the React SPA ships in the published package instead of relying on legacy fallbackbuild-dashboardjob), catching build failures before mergenpx selftune@latest doctoras the primary proof command (directly tests the published npm package), with skill-based install as secondaryProof flow: After merge, users can verify the published package works: (1)
npx selftune@latest doctor, (2)npx selftune@latest status, (3)npx selftune@latest dashboard.