Skip to content

Conversation

@Nesopie
Copy link
Collaborator

@Nesopie Nesopie commented Dec 2, 2025

Note

Replace @zk-kit/binary-merkle-root.circom@2.0.0 with @selfxyz/binary-merkle-root.circom@^0.0.1 and update lockfile.

  • Dependencies:
    • Replace @zk-kit/binary-merkle-root.circom@2.0.0 with npm:@selfxyz/binary-merkle-root.circom@^0.0.1 in circuits/package.json.
    • Update yarn.lock to resolve @selfxyz/binary-merkle-root.circom@0.0.1 and associated checksums.

Written by Cursor Bugbot for commit 9d59f9e. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated circuit package dependency source for the binary merkle root library.

✏️ Tip: You can customize this high-level summary in your review settings.

@Nesopie Nesopie merged commit cdce88c into dev Dec 2, 2025
12 of 13 checks passed
@Nesopie Nesopie deleted the fix/bin-merkle-tree branch December 2, 2025 15:55
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The dependency for @zk-kit/binary-merkle-root.circom is reconfigured to reference a self-hosted scoped package via npm alias, changing from the public version 2.0.0 to npm:@selfxyz/binary-merkle-root.circom@^0.0.1.

Changes

Cohort / File(s) Change Summary
Dependency Alias Update
circuits/package.json
@zk-kit/binary-merkle-root.circom dependency changed from fixed version "2.0.0" to npm alias "npm:@selfxyz/binary-merkle-root.circom@^0.0.1", shifting package source from public npm registry to self-hosted scoped package

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the self-hosted package (@selfxyz/binary-merkle-root.circom@^0.0.1) exists and is properly maintained
  • Confirm the version bump from 2.0.0 to ^0.0.1 doesn't introduce breaking changes in the circom library interface or generated artifacts
  • Ensure all dependent code paths continue to function correctly with the aliased package

Possibly related PRs

Suggested reviewers

  • transphorm
  • remicolin

Poem

📦 A package takes flight, from public to home,
Self-hosted and rooted, no longer to roam,
Alias in place, the circom roots deep,
Version by version, the merkles still steep! 🌳

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/bin-merkle-tree

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7899c23 and 9d59f9e.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • circuits/package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants