Skip to content

chore: skip nullifier tests#1527

Merged
Nesopie merged 1 commit intodevfrom
fix/aadhaar-tests
Dec 24, 2025
Merged

chore: skip nullifier tests#1527
Nesopie merged 1 commit intodevfrom
fix/aadhaar-tests

Conversation

@Nesopie
Copy link
Collaborator

@Nesopie Nesopie commented Dec 24, 2025

Note

Disables select Register Aadhaar circuit assertions to narrow test scope.

  • In register_aadhaar.test.ts, mark as skipped (it.skip) the tests verifying nullifier/commitment outputs and the case for different QR data.

Written by Cursor Bugbot for commit 43abae5. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Tests
    • Two test cases have been skipped in the registration verification module.

✏️ Tip: You can customize this high-level summary in your review settings.

@Nesopie Nesopie merged commit a10149b into dev Dec 24, 2025
1 of 2 checks passed
@Nesopie Nesopie deleted the fix/aadhaar-tests branch December 24, 2025 10:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Two test cases in the Aadhaar registration circuit test suite were skipped by converting it() to it.skip(). No logic or functionality was altered; the tests are simply bypassed during execution.

Changes

Cohort / File(s) Summary
Test Suite Modifications
circuits/tests/register/register_aadhaar.test.ts
Two test cases converted from active to skipped: "should pass constrain and output correct nullifier and commitment" and "should pass for different qr data". No functional changes to test logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🧪 Two tests take a well-deserved break,
Skipping past with a gentle shake,
No logic bent, no flows did shift,
Just paused for now—a momentary drift. ⏭️

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/aadhaar-tests

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 508c183 and 43abae5.

📒 Files selected for processing (1)
  • circuits/tests/register/register_aadhaar.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

await circuit.checkConstraints(w);
});
it('should pass constrain and output correct nullifier and commitment', async function () {
it.skip('should pass constrain and output correct nullifier and commitment', async function () {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security-critical nullifier verification tests disabled without explanation

Two tests that verify the correctness of nullifier output for the Aadhaar register circuit are being skipped. After this change, there are no remaining tests in this file that verify the nullifier value is computed correctly. Nullifiers are typically security-critical in ZK systems for preventing double-usage. These .skip calls may have been intended for local debugging but appear to have been accidentally included in the commit. Without these tests, incorrect nullifier computation could reach production undetected.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant