Skip to content

bugfix: self client provider setup#1851

Merged
transphorm merged 1 commit intodevfrom
justin/fix-generate-key-test-setup
Mar 12, 2026
Merged

bugfix: self client provider setup#1851
transphorm merged 1 commit intodevfrom
justin/fix-generate-key-test-setup

Conversation

@transphorm
Copy link
Copy Markdown
Member

@transphorm transphorm commented Mar 12, 2026

Summary

Test plan


Native Consolidation Checklist

  • CONTRACTS.md reviewed - no unintended contract changes
  • Layer 1 bridge contract tests pass (cd app && yarn jest:run / yarn workspace @selfxyz/rn-sdk-test-app test)
  • Layer 3 builds pass (app iOS, RN test app iOS, RN test app Android)
  • Layer 4 manual smoke test signed off (if consolidation PR)
  • No new native business logic added (logic belongs in TypeScript)

Summary by CodeRabbit

  • Tests
    • Enhanced test infrastructure with additional mock implementations for cryptographic operations.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@transphorm transphorm changed the title fix bugfix: self client provider setup Mar 12, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 12, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7d5a6538-e926-4a72-a8c1-8a8ed216168e

📥 Commits

Reviewing files that changed from the base of the PR and between a56edba and f6f5be3.

📒 Files selected for processing (1)
  • app/tests/__setup__/selfClientProvider.ts

📝 Walkthrough

Walkthrough

This PR extends the mock CryptoAdapter in the test setup file by adding two stub methods: generateKey() and getPublicKey(). These additions enable testing of components that depend on these cryptographic operations without requiring actual key generation or public key retrieval.

Changes

Cohort / File(s) Summary
Mock CryptoAdapter Extensions
app/tests/__setup__/selfClientProvider.ts
Added generateKey(keyRef) returning an object with keyRef, and getPublicKey(_keyRef) returning a Uint8Array to the mockCrypto implementation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🔐 Mock keys dance in silence,
Async whispers of public fate,
Tests now sing in cryptic truths,
No real secrets need translate! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch justin/fix-generate-key-test-setup
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm merged commit f1ca565 into dev Mar 12, 2026
17 of 18 checks passed
@transphorm transphorm deleted the justin/fix-generate-key-test-setup branch March 12, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant