Skip to content

docs: add WV-07 and WV-08 specs for proving machine in webview-app#1861

Merged
seshanthS merged 1 commit intodevfrom
specs/wv-07-08-proving-machine-webview
Mar 24, 2026
Merged

docs: add WV-07 and WV-08 specs for proving machine in webview-app#1861
seshanthS merged 1 commit intodevfrom
specs/wv-07-08-proving-machine-webview

Conversation

@seshanthS
Copy link
Copy Markdown
Collaborator

@seshanthS seshanthS commented Mar 24, 2026

WV-07 covers SelfClient assembly: exporting useProvingStore from the browser entry point, mapping bridge adapters to SDK interfaces, creating a keychain-backed DocumentsAdapter via the existing secureStorage bridge, and wiring a real SelfClient in the webview-app provider.

WV-08 covers the tunnel proving flow: replacing the mock 3-second timer with real provingMachine integration (register → disclose), storing Sumsub KYC results as KycData documents in native keychain, and driving UI from proving state transitions.

Summary

Test plan


Native Consolidation Checklist

  • CONTRACTS.md reviewed - no unintended contract changes
  • Layer 1 bridge contract tests pass (cd app && yarn jest:run / yarn workspace @selfxyz/rn-sdk-test-app test)
  • Layer 3 builds pass (app iOS, RN test app iOS, RN test app Android)
  • Layer 4 manual smoke test signed off (if consolidation PR)
  • No new native business logic added (logic belongs in TypeScript)

Summary by CodeRabbit

  • Documentation
    • Added planning specifications for two new WebView workstream initiatives (WV-07 and WV-08)
    • New documentation outlines upcoming proving machine integration and enhanced verification workflow capabilities
    • Backlog and active plans updated with new high-priority planning items

WV-07 covers SelfClient assembly: exporting useProvingStore from the
browser entry point, mapping bridge adapters to SDK interfaces, creating
a keychain-backed DocumentsAdapter via the existing secureStorage bridge,
and wiring a real SelfClient in the webview-app provider.

WV-08 covers the tunnel proving flow: replacing the mock 3-second timer
with real provingMachine integration (register → disclose), storing
Sumsub KYC results as KycData documents in native keychain, and driving
UI from proving state transitions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@seshanthS seshanthS merged commit 3eae9dc into dev Mar 24, 2026
11 of 12 checks passed
@seshanthS seshanthS deleted the specs/wv-07-08-proving-machine-webview branch March 24, 2026 12:21
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a78d9f6f-3be6-4578-8745-8eb96342e98b

📥 Commits

Reviewing files that changed from the base of the PR and between bd2e3c6 and 96ca33b.

📒 Files selected for processing (3)
  • specs/projects/sdk/workstreams/webview/SPEC.md
  • specs/projects/sdk/workstreams/webview/plans/WV-07-selfclient-proving-assembly.md
  • specs/projects/sdk/workstreams/webview/plans/WV-08-tunnel-proving-flow.md

📝 Walkthrough

Walkthrough

Adds specification documents for two new WebView workstream items. WV-07 details wiring a real SDK SelfClient into the WebView app by exporting proving state hooks, implementing a keychain-backed documents adapter, and adding a Buffer polyfill. WV-08 describes an end-to-end tunnel proving flow integrating Sumsub KYC results with sequential circuit proving (register → disclose).

Changes

Cohort / File(s) Summary
Workstream Specification
specs/projects/sdk/workstreams/webview/SPEC.md
Added two new backlog items (WV-07, WV-08) to active-plan tables with Status: Ready and High priority, linking to new plan documents.
WV-07 Implementation Plan
specs/projects/sdk/workstreams/webview/plans/WV-07-selfclient-proving-assembly.md
Detailed plan for wiring real SDK SelfClient into WebView app: exporting useProvingStore, ProvingState, and getPostVerificationRoute from browser.ts; creating keychain-backed DocumentsAdapter; building SDK adapter mapping layer; updating SelfClientProvider to construct real SelfClient; adding SDK dependencies; and adding Buffer polyfill to main.tsx.
WV-08 Flow Plan
specs/projects/sdk/workstreams/webview/plans/WV-08-tunnel-proving-flow.md
Specification for end-to-end tunnel proving workflow: replacing mock proving timer with real useProvingStore state handling, wiring Sumsub KYC attestation into keychain storage, mapping proving-machine states to UI screens, and gating circuit execution at ready_to_prove state.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • aaronmgdr
  • shazarre

Poem

🔐 A SelfClient awakens in the WebView's gleam,
Proving machines hum with cryptographic dream,
Keys in keychains, adapters aligned,
Tunnel flows dancing—register then disclose entwined,
From mock to real, the proving machine takes flight! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch specs/wv-07-08-proving-machine-webview

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant