fix gitleaks 04/02/26#1920
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6710520052
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| paths = [ | ||
| '''(?:^|/)Podfile\.lock$''', | ||
| '''(?:^|/)app/src/services/points/constants\.ts$''', | ||
| '''(?:^|/)packages/native-shell-android/src/main/assets/self-wallet/assets/.*\.js$''', |
There was a problem hiding this comment.
Narrow gitleaks allowlist for native shell JS bundles
Allowlisting packages/native-shell-android/src/main/assets/self-wallet/assets/.*\.js disables secret scanning for every committed JS asset in that bundle directory, not just the known false positives. In practice, if a real credential (API key, token, private key) is accidentally embedded in the shipped web bundle, gitleaks will now miss it entirely, which is a security regression introduced by this commit; prefer a targeted regex allowlist for the specific false-positive pattern(s) instead of path-wide exclusion.
Useful? React with 👍 / 👎.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single line added to Gitleaks configuration to exempt JavaScript files located in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Test plan
Native Consolidation Checklist
cd app && yarn jest:run/yarn workspace @selfxyz/rn-sdk-test-app test)Summary by CodeRabbit