Skip to content

Add Firebase Analytics and upgrade app dependencies#1944

Merged
transphorm merged 3 commits intodevfrom
justin/more-build-improvements
Apr 8, 2026
Merged

Add Firebase Analytics and upgrade app dependencies#1944
transphorm merged 3 commits intodevfrom
justin/more-build-improvements

Conversation

@transphorm
Copy link
Copy Markdown
Member

@transphorm transphorm commented Apr 8, 2026

Summary

  • Add @react-native-firebase/analytics to the app with static framework linking for Firebase XCFrameworks
  • Upgrade packages: axios 1.14→1.15, react-native-webview 13.16.0→13.16.1, typescript-eslint 8.39→8.58, lottie-react-native 7.2.2→7.3.6, Yarn 4.12→4.13
  • Clean up app package.json by removing duplicate resolutions block (already covered by overrides)
  • Relax SDK peer deps: lottie-react-native now ^7.2.2, add optional react-native-blur-effect

Changes

React Native app

  • Add @react-native-firebase/analytics dependency
  • Set $RNFirebaseAsStaticFramework = true in Podfile for correct XCFramework linking
  • Update Podfile.lock with FirebaseAnalytics, GoogleAppMeasurement, and RNFBAnalytics pods
  • Remove redundant resolutions block (duplicated by overrides)
  • Bump axios ^1.14.0^1.15.0, react-native-webview 13.16.013.16.1
  • Bump @typescript-eslint/eslint-plugin and parser ^8.39.0^8.58.1

SDK core

  • Bump lottie-react-native dev dep 7.2.27.3.6
  • Relax lottie-react-native peer dep from exact 7.2.2 to ^7.2.2
  • Add react-native-blur-effect as optional peer dependency

Config/infra

  • Bump packageManager from yarn@4.12.0 to yarn@4.13.0
  • Add react-native-blur-effect pinned resolution at root

Test Plan

  • yarn lint && yarn types passes
  • cd packages/mobile-sdk-alpha && yarn test && yarn types
  • iOS pod install succeeds with new Firebase Analytics pod
  • App builds and runs on iOS simulator
  • Firebase Analytics events fire correctly

Native Consolidation Checklist

  • CONTRACTS.md reviewed - no unintended contract changes
  • Layer 1 bridge contract tests pass (cd app && yarn jest:run / yarn workspace @selfxyz/rn-sdk-test-app test)
  • Layer 3 builds pass (app iOS, RN test app iOS, RN test app Android)
  • Layer 4 manual smoke test signed off (if consolidation PR)
  • No new native business logic added (logic belongs in TypeScript)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Added Firebase Analytics to project dependencies
    • Bumped several libraries and development tools for compatibility and stability
    • Updated package manager metadata (Yarn) version
    • Adjusted native iOS pod integration to change how Firebase frameworks are linked
    • Updated optional/native peer dependency declarations (animation and blur-related packages)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
self-webview-app Ignored Ignored Preview Apr 8, 2026 5:24pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

Dependency, resolution, and tooling updates: added @react-native-firebase/analytics; moved/adjusted package resolutions between app/package.json and root package.json; bumped several dependency versions and Yarn; updated lottie-react-native peer/dev deps and added optional react-native-blur-effect peer; set $RNFirebaseAsStaticFramework = true in app/ios/Podfile.

Changes

Cohort / File(s) Summary
App package manifest
app/package.json
Removed top-level resolutions entries (pins for punycode, react-native-blur-effect, react-native-webview) leaving overrides as source of truth; added @react-native-firebase/analytics ^21.14.0; bumped axios, react-native-webview, and TypeScript ESLint packages.
Repo root manifest
package.json
Added react-native-blur-effect resolution at 1.1.3; bumped packageManager Yarn version from 4.12.0 to 4.13.0.
Mobile SDK package
packages/mobile-sdk-alpha/package.json
Updated lottie-react-native devDependency 7.2.2 → 7.3.6; relaxed peerDependency to ^7.2.2; added optional peer react-native-blur-effect ^1.1.3 (via peerDependencies + peerDependenciesMeta).
iOS Podfile
app/ios/Podfile
Added global assignment $RNFirebaseAsStaticFramework = true to force RNFirebase pods to be built/treated as static frameworks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately summarizes the main changes: adding Firebase Analytics and upgrading app dependencies, which aligns with the primary work in this changeset.
Description check ✅ Passed The PR description is comprehensive and covers all required template sections including summary, detailed changes, and test plan checklist, though checklist items remain unchecked.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch justin/more-build-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm changed the title updates Add Firebase Analytics and upgrade app dependencies Apr 8, 2026
@transphorm transphorm merged commit 77df53b into dev Apr 8, 2026
42 checks passed
@transphorm transphorm deleted the justin/more-build-improvements branch April 8, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant