Remove Points and Self Apps screens, update navigation and copy#1945
Remove Points and Self Apps screens, update navigation and copy#1945transphorm merged 8 commits intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoves points-related UI, screens, hooks, routes, and tests; replaces direct support-form calls with a new hook; updates WebView fallback/trusted domains and referral/proof flows; and adds a 30s SplashScreen initialization timeout plus assorted small refactors. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
transphorm
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2978a361bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2b277c2e-5d6a-4b2e-be0a-e4be18c8ce20
📒 Files selected for processing (23)
app/src/components/PointHistoryList.tsxapp/src/components/navbar/Points.tsxapp/src/components/navbar/PointsNavBar.tsxapp/src/consts/links.tsapp/src/hooks/useEarnPointsFlow.tsapp/src/hooks/usePoints.tsapp/src/hooks/usePointsGuardrail.tsapp/src/hooks/useTestReferralFlow.tsapp/src/navigation/app.tsxapp/src/navigation/home.tsapp/src/navigation/types.tsapp/src/screens/account/settings/CloudBackupScreen.tsxapp/src/screens/app/GratificationScreen.tsxapp/src/screens/app/ReferralScreen.tsxapp/src/screens/home/HomeScreen.tsxapp/src/screens/home/PointsInfoScreen.tsxapp/src/screens/shared/WebViewScreen.tsxapp/src/screens/verification/ProofRequestStatusScreen.tsxapp/tests/src/consts/links.test.tsapp/tests/src/hooks/useEarnPointsFlow.test.tsapp/tests/src/navigation.test.tsxapp/tests/src/screens/GratificationScreen.test.tsxapp/tests/src/screens/home/PointsInfoScreen.test.tsx
💤 Files with no reviewable changes (17)
- app/tests/src/consts/links.test.ts
- app/src/consts/links.ts
- app/tests/src/navigation.test.tsx
- app/src/components/navbar/PointsNavBar.tsx
- app/src/navigation/app.tsx
- app/src/hooks/usePointsGuardrail.ts
- app/src/screens/app/GratificationScreen.tsx
- app/src/navigation/home.ts
- app/tests/src/screens/home/PointsInfoScreen.test.tsx
- app/src/hooks/usePoints.ts
- app/src/navigation/types.ts
- app/tests/src/screens/GratificationScreen.test.tsx
- app/src/screens/home/PointsInfoScreen.tsx
- app/tests/src/hooks/useEarnPointsFlow.test.ts
- app/src/components/navbar/Points.tsx
- app/src/components/PointHistoryList.tsx
- app/src/hooks/useEarnPointsFlow.ts
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
app/src/screens/app/SplashScreen.tsx (1)
51-69:⚠️ Potential issue | 🟠 MajorInitialize native modules before biometrics access
checkBiometricsAvailable()runs beforeinitializeNativeModules(). On cold start, this can fail or mis-detect biometrics support and persist the wrong value to settings. Move the biometrics check after native initialization (or gate it onmodulesReady).Proposed fix
- checkBiometricsAvailable() - .then(setBiometricsAvailable) - .catch(err => { - console.warn('Error checking biometrics availability', err); - }); - const loadDataAndDetermineNextScreen = async () => { const startTime = Date.now(); const elapsed = () => `${Date.now() - startTime}ms`; try { const modulesReady = await initializeNativeModules(); console.log( `SplashScreen: initializeNativeModules complete (${elapsed()})`, ); if (!modulesReady) { console.warn( 'Native modules not ready, proceeding with limited functionality', ); + } else { + await checkBiometricsAvailable() + .then(setBiometricsAvailable) + .catch(err => { + console.warn('Error checking biometrics availability', err); + }); }As per coding guidelines: "Native module initialization with
initializeNativeModules()must occur before any native operations."
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 98319d2e-f9a3-4e6c-9b25-049cabf27052
📒 Files selected for processing (1)
app/src/screens/app/SplashScreen.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b7f1babc-748f-4dc9-a3d0-a3a4c4a68e92
📒 Files selected for processing (2)
app/src/screens/documents/scanning/DocumentNFCTroubleScreen.tsxapp/tests/src/navigation.test.tsx
💤 Files with no reviewable changes (1)
- app/tests/src/navigation.test.tsx
1 participant
Summary
useRegisterReferralinstead of routing through the points/gratification pipelineappsUrl,returnToScreen: 'Points')clearDeepLinkReferrerran even on registration failurecleanSelfApp()delayed cleanup against a new proof session starting within the 2s windowChanges
React Native app
Points.tsx,PointsNavBar.tsx,PointsInfoScreen.tsx,GratificationScreen.tsxPointHistoryList.tsxuseEarnPointsFlow.ts,usePointsGuardrail.ts,usePoints.tsuseOpenSupportForm— navigates to the in-app WebView with the support form URL, replacingopenSupportForm()which usedLinking.openURLuseRegisterReferraldirectly instead of routing throughuseEarnPointsFlow; fixedhandleReferralConfirmedto preservedeepLinkReferrerwhenregisterReferralfails (early return on failure)cleanSelfApp()to only run when the proving session hasn't changed (prevents race condition if user starts a new proof within 2s)openSupportForm()touseOpenSupportFormhookopenSupportFormfunction andLinking/Alertimports (text constants retained)notion.sitetoTRUSTED_DOMAINSfor the support formreturnToScreen: 'Points'type and navigation; cleaned stale commented-out referencesapps.self.xyz→self.xyzPoints,PointsInfo,Gratificationroutes and typesappsUrlfromlinks.tsTests
navigation.test.tsxexpected screen list (removedPoints,PointsInfo,Gratification)links.test.ts(removedappsUrlassertion)useEarnPointsFlow.test.ts,GratificationScreen.test.tsx,PointsInfoScreen.test.tsxLinear Issues
Figma
Test Plan
tsc --noEmitpasseseslintpasses (zero errors/warnings on all changed files)appsUrlassertion)Native Consolidation Checklist
cd app && yarn jest:run/yarn workspace @selfxyz/rn-sdk-test-app test)🤖 Generated with Claude Code
Summary by CodeRabbit
Removed Features
Updates
Improvements
Tests