Rename KYC_TEE_URL and fix nav header regressions#1948
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis pull request renames the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 19220ca7-8ead-4537-becb-3b0547e39325
📒 Files selected for processing (11)
.github/workflows/mobile-deploy.ymlapp/env.sampleapp/env.tsapp/src/components/navbar/DefaultNavBar.tsxapp/src/hooks/useKycWebSocket.tsapp/src/integrations/kyc/kycService.tsapp/src/navigation/account.tsapp/src/navigation/documents.tsapp/src/navigation/home.tspackages/webview-app/src/utils/kycAttestation.tspackages/webview-app/src/utils/kycProvider.ts
Summary
DIDIT_TEE_URL/VITE_DIDIT_TEE_URLenv vars toKYC_TEE_URL/VITE_KYC_TEE_URLacross app, webview-app, and CI — completing the platform-agnostic rename from Rename KYC references to be platform agnostic #1947undefinedstyle properties were overriding the baseadvercasefont (introduced in [SELF-2033] bugfix: clipped card header #1778)headerTintColor: blackandheaderBackTitle: 'close'to Settings and 6 other screens so back/close buttons render visiblyChanges
React Native app
app/env.ts,app/env.sample— renameDIDIT_TEE_URL→KYC_TEE_URLapp/src/hooks/useKycWebSocket.ts,app/src/integrations/kyc/kycService.ts— update@envimportapp/src/components/navbar/DefaultNavBar.tsx— only spread defined style properties into Title to preventundefinedfrom overriding base fontapp/src/navigation/account.ts— addheaderBackTitle: 'close'+headerTintColor: blackto Settings; addheaderTintColorto CloudBackupSettings, ProofSettings, ShowRecoveryPhraseapp/src/navigation/documents.ts— addheaderTintColor: blackto ManageDocuments, DocumentDataInfoapp/src/navigation/home.ts— addheaderTintColor: blackto ProofHistory, ProofHistoryDetailWebView app
packages/webview-app/src/utils/kycAttestation.ts,kycProvider.ts— renameDIDIT_TEE_URL→KYC_TEE_URL,VITE_DIDIT_TEE_URL→VITE_KYC_TEE_URLConfig/infra
.github/workflows/mobile-deploy.yml— renameDIDIT_TEE_URLsecret refs toKYC_TEE_URL(both iOS and Android jobs)Test Plan
yarn lint && yarn typespassesKYC_TEE_URLGitHub secret (rename fromDIDIT_TEE_URL)Native Consolidation Checklist
cd app && yarn jest:run/yarn workspace @selfxyz/rn-sdk-test-app test)🤖 Generated with Claude Code
Summary by CodeRabbit
Chores
Bug Fixes
Style