Skip to content

Rename KYC_TEE_URL and fix nav header regressions#1948

Merged
transphorm merged 3 commits intodevfrom
justin/minor-clean-up-prep-for-release
Apr 9, 2026
Merged

Rename KYC_TEE_URL and fix nav header regressions#1948
transphorm merged 3 commits intodevfrom
justin/minor-clean-up-prep-for-release

Conversation

@transphorm
Copy link
Copy Markdown
Member

@transphorm transphorm commented Apr 9, 2026

Summary

  • Rename DIDIT_TEE_URL / VITE_DIDIT_TEE_URL env vars to KYC_TEE_URL / VITE_KYC_TEE_URL across app, webview-app, and CI — completing the platform-agnostic rename from Rename KYC references to be platform agnostic #1947
  • Fix DefaultNavBar header text regression where undefined style properties were overriding the base advercase font (introduced in [SELF-2033] bugfix: clipped card header #1778)
  • Add missing headerTintColor: black and headerBackTitle: 'close' to Settings and 6 other screens so back/close buttons render visibly

Changes

React Native app

  • app/env.ts, app/env.sample — rename DIDIT_TEE_URLKYC_TEE_URL
  • app/src/hooks/useKycWebSocket.ts, app/src/integrations/kyc/kycService.ts — update @env import
  • app/src/components/navbar/DefaultNavBar.tsx — only spread defined style properties into Title to prevent undefined from overriding base font
  • app/src/navigation/account.ts — add headerBackTitle: 'close' + headerTintColor: black to Settings; add headerTintColor to CloudBackupSettings, ProofSettings, ShowRecoveryPhrase
  • app/src/navigation/documents.ts — add headerTintColor: black to ManageDocuments, DocumentDataInfo
  • app/src/navigation/home.ts — add headerTintColor: black to ProofHistory, ProofHistoryDetail

WebView app

  • packages/webview-app/src/utils/kycAttestation.ts, kycProvider.ts — rename DIDIT_TEE_URLKYC_TEE_URL, VITE_DIDIT_TEE_URLVITE_KYC_TEE_URL

Config/infra

  • .github/workflows/mobile-deploy.yml — rename DIDIT_TEE_URL secret refs to KYC_TEE_URL (both iOS and Android jobs)

Test Plan

  • yarn lint && yarn types passes
  • Verify Settings screen shows close (X) button and title in advercase font
  • Verify sub-screens (Proof Settings, Cloud Backup, Manage Documents, etc.) show visible back chevron
  • Add KYC_TEE_URL GitHub secret (rename from DIDIT_TEE_URL)

Native Consolidation Checklist

  • CONTRACTS.md reviewed - no unintended contract changes
  • Layer 1 bridge contract tests pass (cd app && yarn jest:run / yarn workspace @selfxyz/rn-sdk-test-app test)
  • Layer 3 builds pass (app iOS, RN test app iOS, RN test app Android)
  • Layer 4 manual smoke test signed off (if consolidation PR)
  • No new native business logic added (logic belongs in TypeScript)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores

    • Renamed environment variable for KYC endpoints across deployment workflows, app configuration, integrations, and webview utilities (DIDIT_TEE_URL → KYC_TEE_URL).
  • Bug Fixes

    • Fixed navbar title styling to properly handle undefined style properties.
  • Style

    • Enhanced navigation header appearance with consistent color styling across multiple screens, including improved back button labels on Settings.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
self-webview-app Ignored Ignored Preview Apr 9, 2026 10:19am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: af631742-e73c-4b13-9843-148b84c0f486

📥 Commits

Reviewing files that changed from the base of the PR and between 0a92f8d and 25db341.

📒 Files selected for processing (2)
  • app/env.ts
  • app/src/components/navbar/DefaultNavBar.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • app/src/components/navbar/DefaultNavBar.tsx
  • app/env.ts

📝 Walkthrough

Walkthrough

This pull request renames the DIDIT_TEE_URL environment variable to KYC_TEE_URL across configs and integration code, updates KYC/TEE connection points to use the new variable, adds headerTintColor: black to several navigation screens, and changes DefaultNavBar style construction to conditionally include font properties.

Changes

Cohort / File(s) Summary
Environment Variable Renaming
/.github/workflows/mobile-deploy.yml, app/env.sample, app/env.ts
Replaced DIDIT_TEE_URL with KYC_TEE_URL in CI workflow env, sample env file, and exported TypeScript constant (same fallback).
KYC/TEE Integration Updates
app/src/hooks/useKycWebSocket.ts, app/src/integrations/kyc/kycService.ts, packages/webview-app/src/utils/kycAttestation.ts, packages/webview-app/src/utils/kycProvider.ts
Switched Socket.IO and HTTP session endpoints to read KYC_TEE_URL instead of DIDIT_TEE_URL; console/log messages and constructed URLs updated accordingly.
Navigation Header Styling
app/src/navigation/account.ts, app/src/navigation/documents.ts, app/src/navigation/home.ts
Added headerTintColor: black to multiple screen options; imported black constant in home navigation file; minor headerBackTitle addition for Settings.
Component Style Logic
app/src/components/navbar/DefaultNavBar.tsx
Refactored NavBar.Title style to include fontFamily, fontSize, and fontWeight only when truthy via conditional object spreads (avoids setting keys to undefined).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: renaming KYC_TEE_URL env vars and fixing navigation header display regressions.
Description check ✅ Passed The description provides comprehensive coverage of changes across all affected files, includes a test plan matching the template, and includes the native consolidation checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch justin/minor-clean-up-prep-for-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm changed the title Justin/minor clean up prep for release Rename DIDIT_TEE_URL to KYC_TEE_URL and fix nav header regressions Apr 9, 2026
@transphorm transphorm changed the title Rename DIDIT_TEE_URL to KYC_TEE_URL and fix nav header regressions Rename KYC_TEE_URL and fix nav header regressions Apr 9, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19220ca7-8ead-4537-becb-3b0547e39325

📥 Commits

Reviewing files that changed from the base of the PR and between b13ec9a and 0a92f8d.

📒 Files selected for processing (11)
  • .github/workflows/mobile-deploy.yml
  • app/env.sample
  • app/env.ts
  • app/src/components/navbar/DefaultNavBar.tsx
  • app/src/hooks/useKycWebSocket.ts
  • app/src/integrations/kyc/kycService.ts
  • app/src/navigation/account.ts
  • app/src/navigation/documents.ts
  • app/src/navigation/home.ts
  • packages/webview-app/src/utils/kycAttestation.ts
  • packages/webview-app/src/utils/kycProvider.ts

Comment thread app/env.ts Outdated
@transphorm transphorm merged commit c3a805c into dev Apr 9, 2026
30 checks passed
@transphorm transphorm deleted the justin/minor-clean-up-prep-for-release branch April 9, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant