Skip to content

use package extensions#1949

Merged
transphorm merged 1 commit intodevfrom
justin/use-package-extensions
Apr 10, 2026
Merged

use package extensions#1949
transphorm merged 1 commit intodevfrom
justin/use-package-extensions

Conversation

@transphorm
Copy link
Copy Markdown
Member

@transphorm transphorm commented Apr 9, 2026

Summary

Test plan


Native Consolidation Checklist

  • CONTRACTS.md reviewed - no unintended contract changes
  • Layer 1 bridge contract tests pass (cd app && yarn jest:run / yarn workspace @selfxyz/rn-sdk-test-app test)
  • Layer 3 builds pass (app iOS, RN test app iOS, RN test app Android)
  • Layer 4 manual smoke test signed off (if consolidation PR)
  • No new native business logic added (logic belongs in TypeScript)

Summary by CodeRabbit

  • Chores
    • Updated package dependency configuration for improved handling of optional dependencies.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
self-webview-app Ignored Ignored Apr 9, 2026 9:02pm

Request Review

@transphorm transphorm changed the title clean up resolutions warnings use package extensions Apr 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0b0d4e0-d6ce-4a11-802f-f77fe5b10e7b

📥 Commits

Reviewing files that changed from the base of the PR and between 4bae15d and 0a6ba15.

📒 Files selected for processing (1)
  • .yarnrc.yml

📝 Walkthrough

Walkthrough

Updated .yarnrc.yml to add a packageExtensions configuration for @selfxyz/euclid@* that marks react-native-blur-effect as an optional peer dependency.

Changes

Cohort / File(s) Summary
Yarn Configuration
.yarnrc.yml
Added packageExtensions entry targeting @selfxyz/euclid@* to declare react-native-blur-effect as optional peer dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is an empty template with no actual implementation details, test plan, or summary filled in. Fill in the Summary and Test plan sections with actual details about the packageExtensions change and how it was tested.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title "use package extensions" is directly related to the main change, which adds a packageExtensions configuration to .yarnrc.yml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch justin/use-package-extensions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm merged commit 81bd30e into dev Apr 10, 2026
19 checks passed
@transphorm transphorm deleted the justin/use-package-extensions branch April 10, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant