Skip to content

Fix Android AD_ID permission blocking Play Store upload#1953

Merged
transphorm merged 1 commit intodevfrom
justin/fix-mobile-deploy-pipelines
Apr 10, 2026
Merged

Fix Android AD_ID permission blocking Play Store upload#1953
transphorm merged 1 commit intodevfrom
justin/fix-mobile-deploy-pipelines

Conversation

@transphorm
Copy link
Copy Markdown
Member

@transphorm transphorm commented Apr 10, 2026

Summary

  • Remove the com.google.android.gms.permission.AD_ID permission that Google Play Services/Firebase merges into the Android manifest transitively
  • The Play Store rejected uploads because the app declares it doesn't use advertising ID, but the merged manifest included the permission

Changes

React Native app

  • Added tools:node="remove" for com.google.android.gms.permission.AD_ID in AndroidManifest.xml, matching the existing pattern used for FOREGROUND_SERVICE_MICROPHONE

Test Plan

  • yarn lint && yarn types passes
  • Android build completes successfully (cd app && npx react-native build-android --mode=release or Fastlane)
  • Play Store upload no longer rejected for AD_ID permission

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Removed advertising ID permission declaration to reflect that the app does not utilize advertising identifiers.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
self-webview-app Ignored Ignored Preview Apr 10, 2026 0:30am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a0a0974f-ae5f-4a2e-b0df-af235e09b6e9

📥 Commits

Reviewing files that changed from the base of the PR and between 81bd30e and 3a7660e.

📒 Files selected for processing (1)
  • app/android/app/src/main/AndroidManifest.xml

📝 Walkthrough

Walkthrough

Removed the advertising ID permission declaration from the Android manifest by adding a tools:node="remove" directive for the com.google.android.gms.permission.AD_ID permission, with a comment noting the app does not utilize advertising ID functionality.

Changes

Cohort / File(s) Summary
Android Manifest Permissions
app/android/app/src/main/AndroidManifest.xml
Removed com.google.android.gms.permission.AD_ID permission using tools:node="remove" with inline comment indicating the app does not use advertising ID.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing the AD_ID permission to fix Play Store upload rejection.
Description check ✅ Passed The description includes a clear summary, specific changes made, and a test plan, though test items lack completion status. It provides sufficient context for understanding the PR's purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch justin/fix-mobile-deploy-pipelines

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@transphorm transphorm changed the title fix google play Fix Android AD_ID permission blocking Play Store upload Apr 10, 2026
@transphorm transphorm merged commit b9c5b4a into dev Apr 10, 2026
26 checks passed
@transphorm transphorm deleted the justin/fix-mobile-deploy-pipelines branch April 10, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant