basestring doesn't work in Python 3

[Ayehavgunne]

After attempting to use user-agents with Python 3 I got a NameError due to the use of basestring. I put this in to quickly get it working (for me at least with a minimum of testing).

    try:
        if major is not None and isinstance(major, basestring):
            major = int(major) if major.isdigit() else major
    except NameError:
        if major is not None and isinstance(major, str):
            major = int(major) if major.isdigit() else major
    try:
        if minor is not None and isinstance(minor, basestring):
            minor = int(minor) if minor.isdigit() else minor
    except NameError:
        if minor is not None and isinstance(minor, str):
            minor = int(minor) if minor.isdigit() else minor
    try:
        if patch is not None and isinstance(patch, basestring):
            patch = int(patch) if patch.isdigit() else patch
    except NameError:
        if patch is not None and isinstance(patch, str):
            patch = int(patch) if patch.isdigit() else patch
    try:
        if patch_minor is not None and isinstance(patch_minor, basestring):
            patch_minor = int(patch_minor) if patch_minor.isdigit() else patch_minor
    except NameError:
        if patch_minor is not None and isinstance(patch_minor, str):
            patch_minor = int(patch_minor) if patch_minor.isdigit() else patch_minor

Which replaces this starting at line 40

    if major is not None and isinstance(major, basestring):
        major = int(major) if major.isdigit() else major
    if minor is not None and isinstance(minor, basestring):
        minor = int(minor) if minor.isdigit() else minor
    if patch is not None and isinstance(patch, basestring):
        patch = int(patch) if patch.isdigit() else patch
    if patch_minor is not None and isinstance(patch_minor, basestring):
        patch_minor = int(patch_minor) if patch_minor.isdigit() else patch_minor

I am sure there is a more elegant fix that I am not going to bother looking up this late at night. I might come back to this later.

[Ayehavgunne]

After coming back to this I found the better answer in about 2 seconds.

    from six import string_types
    if major is not None and isinstance(major, string_types):
        major = int(major) if major.isdigit() else major
    if minor is not None and isinstance(minor, string_types):
        minor = int(minor) if minor.isdigit() else minor
    if patch is not None and isinstance(patch, string_types):
        patch = int(patch) if patch.isdigit() else patch
    if patch_minor is not None and isinstance(patch_minor, string_types):
        patch_minor = int(patch_minor) if patch_minor.isdigit() else patch_minor

[selwin]

Having six as a dependency for something as trivial as this seems unnecessary so we can just borrow what's necessary from six:

PY2 = sys.version_info[0] == 2
PY3 = sys.version_info[0] == 3

if PY3:
    string_types = str
else:
    string_types = basestring

[selwin]

Fixed in 171b951