Conversation
bench_col_layout links columnar/session.c which calls sqrt() but was missing math_dep in its dependency list, causing linker failure.
…pecific ranges Add range documentation and #define WL_PLAN_OP__BACKEND_START separating universal operators (0-8, backend-agnostic) from columnar backend operators (9+, use opaque_data). All numeric values unchanged.
Assert all 12 enum values (0-11) plus WL_PLAN_OP__BACKEND_START boundary in test_plan_exchange.c. Locks the universal/backend-specific partition against accidental renumbering.
…classification wl_plan_op_is_backend_specific() and wl_plan_op_is_universal() provide programmatic classification of operators against WL_PLAN_OP__BACKEND_START.
…fic ops Reorganize field-usage comment block into Universal and Backend-specific sections. Fix opaque_data comment to reference all three backend ops (K_FUSION, LFTJ, EXCHANGE) instead of only K_FUSION.
…pecific ops Add _Static_assert verifying WL_PLAN_OP_K_FUSION == WL_PLAN_OP__BACKEND_START to catch boundary drift at compile time. Replace silent default break in dispatch switch with assert for unknown op types in debug builds.
Replace exec_plan.h:259 line-number reference with symbol-only reference to avoid staleness when the enum is reorganized.
…oundary MSVC C mode does not support _Static_assert. Use typedef array trick for MSVC, keep _Static_assert for GCC/Clang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wl_plan_op_type_tenum into universal (0-8) and backend-specific (9+) ranges with#define WL_PLAN_OP__BACKEND_START 9wl_plan_op_is_backend_specific(),wl_plan_op_is_universal()_Static_assertboundary check and debug assertion in columnar eval dispatchmath_depin bench_col_layout build targetDesign decisions
#definesentinel instead of enum member to avoid collision withWL_PLAN_OP_K_FUSION = 9Closes #495
Test plan
_Static_assert(WL_PLAN_OP_K_FUSION == WL_PLAN_OP__BACKEND_START)compileswl_plan_op_t