feat: Swap got for fetch and adds proxy support #316
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naffers
force-pushed
the
github-proxy-implementation-port
branch
from
72e0465 to
24f0319
Compare
naffers
commented
Jan 6, 2022
| const gitlab = authenticate(env) | ||
| .get(`/projects/${owner}%2F${repo}`) | ||
| .times(3) | ||
| .times(1) |
Author
There was a problem hiding this comment.
This was changed intentionally so as to not bloat the diffs with additional logic to facilitate what I can only assume was default retry logic contained in the got module.
If the general approach of swapping out got for fetch is decided to be a good idea, then adding this retry logic should be explored then.
naffers
commented
Jan 6, 2022
| @@ -0,0 +1,8 @@ | |||
| module.exports = class GotPollyFillError extends Error { | |||
Author
There was a problem hiding this comment.
This feels dirty but felt like the path of least resistance without rewriting the error handling
naffers
force-pushed
the
github-proxy-implementation-port
branch
from
24f0319 to
25b6125
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at visualising what changes would be required to align the HTTP client with added proxy support. As discussed in this thread.
There's a fair few differences between the
gotandfetchHTTP clients, which has resulted in what I'd consider some less than desirable changes.Though hopefully this helps visualise some way the extent of the changes being suggested.
For reference the original PR: #229
b3nk3 PR that refreshes the above: #310