Skip to content

refactor: Ignore malformed tags #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2016
Merged

refactor: Ignore malformed tags #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
005d1be
refactor: Ignore malformed tags
badboy Jan 22, 2016
f72ccea
refactor: Reduce code by relying on iterators
badboy Jan 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,25 +19,16 @@ pub fn latest_tag(path: &str) -> Option<Version> {
Ok(repo) => repo,
Err(_) => return None
};
let mut biggest_tag = Version::parse("0.0.0").unwrap();

let tags = match repo.tag_names(None) {
Ok(tags) => tags,
Err(_) => return None
};
if tags.len() == 0 {
return None
}
for tag in tags.iter() {
let tag = tag.unwrap();
let tag = &tag[1..];
let v = Version::parse(tag).expect(&format!("Malformed tag {}", tag));
if v > biggest_tag {
biggest_tag = v;
}
}

Some(biggest_tag)
tags.iter()
.map(|tag| tag.unwrap())
.filter_map(|tag| Version::parse(&tag[1..]).ok())
.max()
}

pub fn version_bump_since_latest(path: &str) -> CommitType {
Expand Down