Skip to content

feat: Project tasks support reference object#240

Merged
hamir-suspect merged 6 commits intomasterfrom
has/tasks-with-tags
Oct 7, 2025
Merged

feat: Project tasks support reference object#240
hamir-suspect merged 6 commits intomasterfrom
has/tasks-with-tags

Conversation

@hamir-suspect
Copy link
Contributor

No description provided.

@hamir-suspect hamir-suspect marked this pull request as ready for review September 26, 2025 15:18
@hamir-suspect hamir-suspect requested a review from dexyk September 26, 2025 15:18
@hamir-suspect hamir-suspect requested a review from Copilot October 6, 2025 10:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new reference object in project tasks and schedulers to replace the deprecated branch field, improving API design and providing better support for different reference types like tags. The implementation maintains backward compatibility by automatically converting between the old branch field and the new reference object during JSON marshaling/unmarshaling.

Key changes:

  • Introduced new Reference struct with Type and Name fields
  • Added custom JSON marshaling/unmarshaling for Task and Scheduler structs to handle backward compatibility
  • Implemented automatic conversion between branch field and reference object based on branch format (detects tag references)

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 3 comments.

File Description
api/models/project_v1_alpha.go Core implementation of Reference struct and backward-compatible marshaling logic for Task and Scheduler
cmd/edit_test.go Comprehensive test coverage for new reference functionality and backward compatibility scenarios
api/models/debug_job_v1_alpha.go Minor style improvement removing unnecessary parentheses from function return type
cmd/create_secret_test.go Cleanup of extra whitespace lines

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hamir-suspect hamir-suspect requested a review from Copilot October 6, 2025 10:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

hamir-suspect and others added 2 commits October 6, 2025 12:41
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hamir-suspect hamir-suspect merged commit 4b65854 into master Oct 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments