Change the when CLI installation procedure #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogyo210
previously approved these changes
Oct 1, 2024
lucaspin
reviewed
Oct 1, 2024
d-stefanovic
reviewed
Oct 2, 2024
lucaspin
previously approved these changes
Oct 10, 2024
DamjanBecirovic
dismissed stale reviews from lucaspin and bogyo210
via
25dcfd2
DamjanBecirovic
force-pushed
the
db/change-when-install-method
branch
from
b2e008a to
25dcfd2
Compare
lucaspin
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on renderedtext/when#33 and the release of the new when CLI version v1.2.0.
We recently introduced the option for customers to choose an agent to run init jobs.
If they choose the agent with the ubuntu2204 image they will have an issue with the
change_infunctionality.For
change_into work we need the when CLI tool which in turn requires Erlang 24 to be installed on the machine and the ubuntu2204 images come with Erlang 25 as the default.This PR changes the way when CLI is packaged and installed.
It adds into the toolbox tarball all the different when CLI binaries for each supported Erlang version.
Later in the installation phase, it installs the correct one based on the available Erlang version on the machine.