Skip to content

[UIK-3694] review other docs after major#2177

Merged
Valeria-Zimnitskaya merged 16 commits intorelease/v16from
UIK-3694/review-other-docs
May 28, 2025
Merged

[UIK-3694] review other docs after major#2177
Valeria-Zimnitskaya merged 16 commits intorelease/v16from
UIK-3694/review-other-docs

Conversation

@sheila-semrush
Copy link
Copy Markdown
Contributor

@sheila-semrush sheila-semrush commented May 23, 2025

Motivation and Context

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@sheila-semrush sheila-semrush marked this pull request as draft May 23, 2025 15:48
@sheila-semrush sheila-semrush marked this pull request as ready for review May 23, 2025 16:28
@sheila-semrush
Copy link
Copy Markdown
Contributor Author

sheila-semrush commented May 23, 2025

@Valeria-Zimnitskaya

  1. Static lint errors are fixed in other PRs ([chore] updated version of csstype #2166 and [UIK-3213][website] added check to dead links #2163). It's better to merge this PR after those.
  2. I've removed the "column-expand" story from the DataTable Example page. I think we can remove this story completely because it's a duplicate of another example with Sorting. But it has to be replaced with another example in one browser test.

@Valeria-Zimnitskaya
Copy link
Copy Markdown
Contributor

@sheila-semrush The script showed me one more broken link [table-group/data-table/data-table-code.md] → "/table-group/data-table/data-table-api#cellrenderprops" — anchor "#cellrenderprops" not found in "table-group/data-table/data-table-api.md"

@sheila-semrush
Copy link
Copy Markdown
Contributor Author

@sheila-semrush The script showed me one more broken link [table-group/data-table/data-table-code.md] → "/table-group/data-table/data-table-api#cellrenderprops" — anchor "#cellrenderprops" not found in "table-group/data-table/data-table-api.md"

fixed

@Valeria-Zimnitskaya Valeria-Zimnitskaya merged commit f634c28 into release/v16 May 28, 2025
7 checks passed
@Valeria-Zimnitskaya Valeria-Zimnitskaya deleted the UIK-3694/review-other-docs branch May 28, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants